Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region-editor config option gets ignored #154

Closed
lublak opened this issue Feb 27, 2024 · 3 comments
Closed

region-editor config option gets ignored #154

lublak opened this issue Feb 27, 2024 · 3 comments
Labels
Milestone

Comments

@lublak
Copy link

lublak commented Feb 27, 2024

Bug/Issue Description:

Currently i try to use the option region-editor in the config to always open the region editor before scanning the video.

Required Information:

dvr-scan.exe --input 10.243.7.181_14.mxg --config dvr-scan.cfg

Expected Behavior:

It should open the Editor and after selecting the region it should run the scan.

Computing Environment:

  • OS: Windows 10
  • Python Version: I downloaded the portable exe
  • OpenCV Version: I downloaded the portable exe
@Breakthrough
Copy link
Owner

Breakthrough commented Mar 5, 2024

Currently you must specify the -r/--region-editor flag explicitly, there is no way to automatically launch it.

I will consider adding a config option to allow always launching the region editor, thanks for the suggestion.

@lublak
Copy link
Author

lublak commented Mar 8, 2024

O i though because there is an option in the default config:
https://github.com/Breakthrough/DVR-Scan/blob/main/dvr-scan.cfg#L25
https://github.com/Breakthrough/DVR-Scan/blob/main/dvr-scan.cfg#L96

@Breakthrough Breakthrough added bug and removed feature labels Mar 17, 2024
@Breakthrough
Copy link
Owner

Good catch, will definitely fix this in the next release. Thanks for the report.

@Breakthrough Breakthrough added this to the v1.6.1 milestone Apr 19, 2024
Breakthrough added a commit that referenced this issue May 12, 2024
Simplify logic for load-region option by merging with regions specified on command line.

Fixes #154.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants