-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support Compiling Entirely from Source #34
Comments
I'm actually building exatly like that, but I set environment to use my build firsts by setting C_INCLUDE_PATH / CPLUS_INCLUDE_PATH / LD_RUN_PATH / LIBRARY_PATH |
I'm suggesting that someone who wants to should be able to change something in the Cmake file from NO to YES (i.e. BUILD_FROM source), and have it 'just work' without any environment variables or external requirements, which means that the expat and minizip sourcecode libs would be checked in to the xlsxio repo. |
I have always thought projects that pull in (or even ship) sources like that are quite dirty. It seams cleaner to me to use stable builds either provided by the distro or built yourself in a seperate location. |
i'd love the former and would be okay with the later. Currently trying to make this and it can't find the minizip i built in a separate location and i had to edit the makefile manually for it to work. EDIT : if you go with the later make sure to get a path for both expat and minizip. also, the former may not be that bad because as you don't have control over the version of the dependencies that are installed, the build could totally fail. if you have them locally you have control over their version and the build pass. |
Which platform are you on? |
managed to install it by editing the makefile and adding manually the minizip lib and include locations. distros where i am are very light and don't have much on them. that's why adding the dependencies in your releases can be useful, or at least the custom paths in your makefile. |
added CMake options to specify custom dependancy paths: ZLIB_DIR/MINIZIP_DIR/LIBZIP_DIR/EXPAT_DIR |
Embed minizip and expat sourcecode (licenses are permissive) and build everything from source using Cmake. Use a flag in Cmake for the user to choose between building entirely from source vs. using FIND_PACKAGES. For those use-cases where the runtime environment is not controllable or known, it should be possible to create a binary that does not rely on the installation and runtime linking of these installed packages.
The text was updated successfully, but these errors were encountered: