Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different php versions #61

Closed
autodeck opened this issue Sep 13, 2018 · 5 comments
Closed

Different php versions #61

autodeck opened this issue Sep 13, 2018 · 5 comments
Labels

Comments

@autodeck
Copy link

Are there any plans to add other versions of php? i.e. 7.0, 7.1?

If not, how would one go about adding one?

@t-geindre
Copy link
Contributor

This is not documented yet but, in a bref.yml file, you can provide your own URL to download the PHP archive:
see https://github.com/mnapoli/bref/blob/master/src/Console/Deployer.php#L148

@mnapoli
Copy link
Member

mnapoli commented Sep 14, 2018

Note that Bref requires 7.1 (https://github.com/mnapoli/bref/blob/master/composer.json#L17) so we probably won't provide 7.0.

I could add new versions but since this is a bit of work for me I would rather wait to see if there is a lot of demand. @autodeck do you need a specific version?

@autodeck
Copy link
Author

@t-geindre - Thanks
@mnapoli - We currently need 7.0.21. Can https://github.com/mnapoli/bref/blob/master/bin/php/build.sh be used to build php for bref or are there other requirements/issues with doing that?

@mnapoli
Copy link
Member

mnapoli commented Sep 17, 2018

@autodeck yes you can use that script and Dockerfile. Keep in mind that the last line (aws s3 cp) uploads to the bref-php bucket, that will not work for you. You can remove it or replace it to store your archive in a bucket of yours.

But again I would advise you to test (locally first) if the Bref classes used in the lambda will work with PHP 7.0.

@mnapoli
Copy link
Member

mnapoli commented Sep 17, 2018

I'm closing this issue for now to keep the issue tracker organized, we'll reopen in needed. Feel free to continue the discussion though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants