Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document event/context for PSR-15 handlers #1009

Merged
merged 5 commits into from
Sep 9, 2021
Merged

Conversation

rdarcy1
Copy link
Contributor

@rdarcy1 rdarcy1 commented Sep 1, 2021

Add documentation for how to get the event and context objects within a PSR-15 handler. I couldn't see it documented already and found it by looking through PRs – related to #543.

Copy link
Contributor

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I just had some minor style suggestions

docs/function/handlers.md Outdated Show resolved Hide resolved
docs/function/handlers.md Outdated Show resolved Hide resolved
docs/function/handlers.md Show resolved Hide resolved
docs/function/handlers.md Outdated Show resolved Hide resolved
docs/function/handlers.md Outdated Show resolved Hide resolved
Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback and then for me it's good to merge, thank you!

docs/function/handlers.md Outdated Show resolved Hide resolved
docs/function/handlers.md Outdated Show resolved Hide resolved
docs/function/handlers.md Outdated Show resolved Hide resolved
@rdarcy1
Copy link
Contributor Author

rdarcy1 commented Sep 8, 2021

Thanks @mnapoli, changes made.

@mnapoli
Copy link
Member

mnapoli commented Sep 9, 2021

Perfect thank you!

@mnapoli mnapoli merged commit 741f6fd into brefphp:master Sep 9, 2021
@rdarcy1 rdarcy1 deleted the patch-1 branch September 9, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants