Pass the Lambda context to handlers #311
Conversation
|
That's really interesting! I think we can do without the |
moved Context object to its own namespace made Context immutable by removing its setters and adding a constructor added a ContextBuilder that will build an immutable Context object adjusted curl's header function to use context builder adjusted tests improved phpdoc blocks
| if ($body === '') { | ||
| throw new \Exception('Empty Lambda runtime API response'); | ||
| } | ||
|
|
||
| $context = $contextBuilder->buildContext(); | ||
|
|
||
| if ($context->getAwsRequestId() === '') { |
There was a problem hiding this comment.
Is a Context with an empty aws request id valid? Maybe this check should be moved in the ContextBuilder? (same question for the other properties of the context, what is the minimal set of data that constitutes a valid context?)
There was a problem hiding this comment.
context can be completely empty but that piece of code expects a non-empty invocation id. It's just a coincidence I'm refetching it from the context instead of keeping around in an $invocationId variable. I could do revert back to using a $invocationId variable in that piece of code and build the context last just before return
There was a problem hiding this comment.
It might ideally be better indeed to forbid having an invalid Context around, but honestly this should never happen and an exception will be thrown if it ever happens. Let's not block this PR longer than necessary.
Thank you for updating your PR @amne.
mnapoli
changed the title
We would like access to the aws-request-id header that is returned by the runtime API.
Our specific use case is that we use the request id to correlate log entries generated by this lambda invocation. Initially we generated our own correlation id but we noticed we can't link them to the cloudwatch entries but we can link them if we use the lambda request id as the correlation id.