Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model predictive sampling methods don't work with Pandas DataFrames #11

Open
brendanhasz opened this issue Nov 14, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@brendanhasz
Copy link
Owner

Because you can't tf.expand_dims on a Pandas DataFrame (or any kind of equivalent operation)... Normally with sampling, will add a singleton dimension as the first dimension to the input data x, and then sample from the variational posteriors (which returns tensors of shape [Nsamples, Shape0, ..., ShapeN]), and that way can broadcast between x and the parameter sample tensors.

Can't cast to tensor and then expand dims, b/c that would break the user's code in pf.Model.__call__, which (might) assume it's a Pandas DataFrame object.

Don't really see a good fix here short of just not supporting DataFrames at all...

@brendanhasz brendanhasz added the bug Something isn't working label Nov 14, 2019
@brendanhasz brendanhasz self-assigned this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant