Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up Issues with empty PollForDecisionTask and PollForActivityTask responses #285

Closed
mfine opened this issue Apr 28, 2016 · 1 comment

Comments

@mfine
Copy link
Contributor

mfine commented Apr 28, 2016

Following up #257. Finally pulled in the fix for #260 and ran into new serialization issues on more missing fields (sorry for the delay!). Looking at the models, it seems like there's more optional attributes to be added here - the responses outlined in #257 for empty polls are still accurate, meaning more overrides.

Empty PollForDecisionTask

Required:

    "DecisionTask":{
      "type":"structure",
      "required":[
        "taskToken",
        "startedEventId",
        "workflowExecution",
        "workflowType",
        "events"
      ],

Actual:

[Raw Response Body] {
{"previousStartedEventId":0,"startedEventId":0}
}

Overrides:

        "DecisionTask": {
            "optionalFields": [
                "taskToken",
                "workflowExecution",
                "workflowType",
                "events"
            ]

Empty PollForActivityTask

Required:

    "ActivityTask":{
      "type":"structure",
      "required":[
        "taskToken",
        "activityId",
        "startedEventId",
        "workflowExecution",
        "activityType"
      ],

Actual:

[Raw Response Body] {
{"startedEventId":0}
}

Overrides:

            "optionalFields": [
                "activityId",
                "taskToken",
                "workflowExecution",
                "activityType"
            ]
This was referenced Apr 28, 2016
@brendanhay
Copy link
Owner

Thanks - closing as I assume #286 + f15725e has this covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants