Remove the gl_common crate #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact glium doesn't even call |
This was referenced Jan 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was the one who proposed this crate. This was in fact a very stupid idea because if we ever do a breaking change the code in
gl_common, everything will break (just like libc).Crates.io show this: https://crates.io/crates/gl_common/reverse_dependencies
Glutin imports the crate to implement the trait in it, and glium imports the trait to call the
loadfunction. All other crates only import gl_common because it is required for gl_generator to compile.Therefore this PR would only break glutin and glium, which I can easily fix.