Update khronos api and remove gl_common. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing this again after some more thought and testing. First, the khronos_api version update is self explanatory; the new version 1.0.0 exists. Next, regarding the removal of gl_common, the initial motivation was to prevent the gfx crate from compiling both libc 0.2.x and libc 0.1.x. It was observed that gfx depended on gfx_gl which depended on gl_common. The idea that gl_common might be unnecessary came when reading this: [brendanzab/gl-rs#359 "Remove the gl_common crate #359"] (brendanzab/gl-rs#359). The gfx crate depends on gfx_gl so to test these changes the following actions were performed on gfx: cargo build cargo run --example triangle cargo run --example cube cargo run --example deferred All of the above built successfully and the examples ran successfully.
|
Looks nice! @bjz ? |
|
👍 Next update to |
brendanzab
added a commit
that referenced
this pull request
Jan 27, 2016
Update khronos api and remove gl_common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this again after some more thought and testing.
First, the khronos_api version update is self explanatory; the new version 1.0.0 exists.
Next, regarding the removal of gl_common, the initial motivation was to prevent the gfx crate from compiling both libc 0.2.x and libc 0.1.x.
It was observed that gfx depended on gfx_gl which depended on gl_common.
The idea that gl_common might be unnecessary came when reading this: https://github.com/bjz/gl-rs/pull/359 "Remove the gl_common crate #359".
The gfx crate depends on gfx_gl so to test these changes the following actions were performed on gfx:
cargo build
cargo run --example triangle
cargo run --example cube
cargo run --example deferred
All of the above built successfully and the examples ran successfully.