Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkedin share issue #243

Closed
Kamleshpaul opened this issue Sep 1, 2023 · 2 comments
Closed

Linkedin share issue #243

Kamleshpaul opened this issue Sep 1, 2023 · 2 comments
Labels
bug Issues and PRs that address that something isn't working properly

Comments

@Kamleshpaul
Copy link
Contributor

rfc-vote/resources/views/components/argument-card/share-links.blade.php

Line 42 in 9821793

:href="'https://www.linkedin.com/sharing/share-offsite/?url=PHP RFC Votes for ' . url()->current()"

i have fix this so many time and and code get overwrite IDK what happen

this is fix of this #179
@Kamleshpaul Kamleshpaul changed the title Why it keep having old code Linkedin share issue Sep 1, 2023
@Plytas
Copy link
Contributor

Plytas commented Sep 1, 2023 •
edited
Loading

Looks like your PR for README #204 had dirty history. It included this change and then a revert of it and it was merged after #179 was merged:
image

You should always keep your fork up to date:
image

And when you create a PR, always do it from a new branch from main.

At this point you'll have to re-submit a new PR with the changes you did in #179

@Kamleshpaul
Copy link
Contributor Author

okay so let me re-submit then thanks @Plytas

@Kamleshpaul Kamleshpaul mentioned this issue Sep 1, 2023
Merged
@brendt brendt closed this as completed Sep 1, 2023
@SerhiiCho SerhiiCho added the bug Issues and PRs that address that something isn't working properly label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues and PRs that address that something isn't working properly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendt @Plytas @Kamleshpaul @SerhiiCho