Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic of pre-check key existence #6

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix logic of pre-check key existence #6

merged 1 commit into from
Feb 11, 2019

Conversation

linxGnu
Copy link
Contributor

@linxGnu linxGnu commented Feb 8, 2019

  • Fix bound checking and logic of number nextPowerOf2 (remove x >> 32 because x already 32 bit)
  • Fix logic of pre-check key existence.

@brentp
Copy link
Owner

brentp commented Feb 8, 2019

LGTM, @shenwei356 would you take a look? It's been a while since I have looked at this code.

@shenwei356
Copy link
Contributor

No problem for me.

@brentp brentp merged commit 30dc0ad into brentp:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linxGnu @brentp @shenwei356