-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from doit
to just
#160
Conversation
Thanks for the PR! I will have a look when I get a chance. |
@FollowTheProcess Could you also update the GitHub Actions workflows so I can see what it will look like to use in real-world scenarios? |
Sure!,I'll take a look at that! I notice I failed the changelog workflow too so I'll sort that out 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial CI run failed due to case-sensitivity issues.
You don't have to worry about this until I have had time to look at the |
Co-authored-by: Brett Cannon <brett@python.org>
Cool, no worries! I could take the changelog fragment out then if you like? Was a nice little intro to Edit: Just thinking how I managed to miss the case issue in |
What OS are you running under? I'm a fish user myself but I have never run into any case-insensitive aspects from the shell. Typically case-sensitivity is a file system thing and both Windows and macOS are case-insensitive by default (hence why the GHA runners are case-sensitive since they are run under Linux). But I'm not too concerned about having to watch out for anything since that's why there's CI. 😉 |
Nope, fragment is good! The contributing documentation will just also need an update since it mentions doit. |
TIL! I'm on macOS, I always thought it was a shell thing.
Cool, this is my next job then 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a couple of suggestions, but I'm not sure if they make sense since this is my first justfile. 😅
@brettcannon Think I got all your suggestions in, let me know if I missed any. My only question was re the use of the walrus in the python script around maybe explaining somewhere that a contributor would need python >=3.8 to run this recipe? |
Just realized that |
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Yeah I left that in because I didn't know if you wanted to completely remove I'll update the Edit: On the As far as I can see the best option might be to |
Yep, this PR is removing all use of doit from the project.
Thanks! And I'm not Docker expert, so if there's anything missing please let me know.
Yep, |
So this is all done with a few tweaks: I've had to Second, it seems that the default python in the devcontainer is 3.7.3 so the walrus does indeed fail! I'm not totally sure how to introduce another version of python, I don't think it's possible to just include something like The only other way I could think is building from source but this seems complex and lengthy for a devcontainer? Are you aware of another way? For now I've just used the 3.7 style syntax to get it working and pushed up, I'll have a look into it in the meantime 👍🏻 |
It's fine to leave out the walrus operator; I'm too lazy to update the dev container just to support it right now. 😄 When you're ready for another review, feel free to refresh my review so it ends back up into my GitHub review queue. |
In that case I think it should be good to go! |
Thanks for all your work on this, @FollowTheProcess ! |
Happy to help! |
doit
to just
Related to discussion item: #128
This PR adds a
justfile
to the root of the project with targets taken from thedodo.py
configuration file.I've run all the recipes locally and they seem to be working fine 🙂
There's a few differences between this and the
dodo.py
implementation:join
currently only accepts 2 arguments (pending next release) I've had to declare a few more variables to get proper file pathsjust
is still new to the project (happy to change to reflect default tasks indodo.py
, thought I'd keep it safe for now!)dodo.py
so you could just pass an array of formats but couldn't getjust
's variable substitution and shell variable expansion playing together nicely so I've just got it as two lines in the task for nowI appreciate I didn't give you chance to respond in the discussion before throwing this PR at you but I was bored and this seemed like fun!
Please feel free to reject if this is no longer wanted 🙂
Thanks!