Use variadic join function in justfile to clean up globals
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Nov 8, 2021
|
Thanks! |
brettcannon
changed the title
justfile to clean up globals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to what we discussed during #160.
justversion 0.10.3 made thejoinfunction accept variadic parameters, this means I could cut down a few of the intermediate global variables I introduced in the referenced PR.I've also added the
skellock.justVSCode extension to the devcontainer as it provides nicer syntax highlighting and some other handy stuff for thejustfile🙂