Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated distutils package #1442

Merged
merged 1 commit into from Nov 16, 2022
Merged

Replace deprecated distutils package #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions brian2/__init__.py
View file
Open in desktop
Expand Up @@ -73,7 +73,7 @@ def _check_dependencies():

# Check for outdated dependency versions
def _check_dependency_version(name, version):
from distutils.version import LooseVersion
from packaging.version import Version
from .core.preferences import prefs
from .utils.logger import get_logger
import sys
Expand All @@ -82,7 +82,7 @@ def _check_dependency_version(name, version):
module = sys.modules[name]
if not isinstance(module.__version__, str): # mocked module
return
if not LooseVersion(module.__version__) >= LooseVersion(version):
if not Version(module.__version__) >= Version(version):
message = f'{name} is outdated (got version {module.__version__}, need version {version})'
if prefs.core.outdated_dependency_error:
raise ImportError(message)
Expand Down