Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue in #1499, by raising a warning if an object gets garbage collected but has never been included in any
Network
. Instead of dealing with the complexities of weak references and theInstanceTracker
, as initially proposed in #1499, this simply uses the__del__
function inBrianObject
. This seems to be working well, and running it against our examples I did not encounter any issues. There are false positives for "artificial" examples like https://brian2.readthedocs.io/en/stable/examples/synapses.efficient_gaussian_connectivity.html, since they createSynapses
but do not ever run a simulation. In principle, we could have another check that only triggers these warnings when there has been arun
at some point, but I am not sure whether it is worth the complication.This code from the forum (where the
define_network
function only returns theNeuronGroup
s, but not theSynapses
) is a good example for the kind of code that will trigger a warning: https://brian.discourse.group/t/synapses-not-functioning/1118