COMMERCE-6410 Headless Commerce Admin Order - better check for missing regionISOCode #100633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f shippingAddress regionISOCode is null
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@igorbeslic see d57ed89 |
liferay-continuous-integration
deleted the
ci-forward-COMMERCE-6410-fix-addresses-with-no-region-id-pr-909-sender-igorbeslic-ts-1617917012754
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-commerce#909 (Took 2
ci:forwardattempts in 13 hours 19 minutes)Console
@igorbeslic
@liferay-commerce
Original pull request comment:
Hi Brian please review
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 28 out of 31 jobs passed in 3 hours 44 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 245d7f1752e0f05da0949b93ec60e181e0cde39c
Upstream Comparison:
Branch GIT ID: 245d7f1752e0f05da0949b93ec60e181e0cde39c
Jenkins Build URL: Acceptance Upstream DXP (master) #1739
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 27 out of 31 jobs PASSED
4 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/027 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at 245d7f1:
test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
16 Tests Passed.
0 Tests Failed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
74 Tests Passed.
1 Test Failed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
69 Tests Passed.
2 Tests Failed.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 245d7f1752e0f05da0949b93ec60e181e0cde39c
Sender Branch:
Branch Name: COMMERCE-6410-fix-addresses-with-no-region-id
1 out of 1jobs PASSEDBranch GIT ID: 6b90d86945524b7791e526842fb6f8a186492c25
1 Successful Jobs:
For more details click here.