Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-127989 Inactive portal users cannot be exported to LDAP #102019

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-appsec#368 (Took 1 ci:forward attempt in 1 hour 46 minutes)
Console

@liferay-appsec

Original pull request comment:

LPS-127989

Dear Reviewer,

My changes intend to enable exporting INACTIVE users to LDAP with the exception of anonymous users.

Related PTR ticket gives an explanation on why creating new method(s) for anonymous user check was necessary and how it was done. I'm not sure about the correct place of these methods, but I didn't find any util class in portal-security-ldap-impl.

Please let me know if you have any questions or concerns.

Thank you,
Istvan

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5b7f2176ebcd6604b28926f00b47a0548aae5b23

Sender Branch:

Branch Name: LPS-127989
Branch GIT ID: 3fe417be7338407e9a2380529a6469cc4fe1fdc6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5b7f2176ebcd6604b28926f00b47a0548aae5b23

Upstream Comparison:

Branch GIT ID: a222817e35bac31751d19c8c1b5c5e00f2949189
Jenkins Build URL: Acceptance Upstream DXP (master) #1878

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: b6534d1...7df1bef

@brianchandotcom
Copy link
Owner

@istvansajtos @stian-sigvartsen see b4fb66a Please verify my changes (ideally with a new integration test)

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-127989-pr-368-sender-liferay-appsec-ts-1621430351807 branch May 27, 2021 10:26
@istvansajtos
Copy link

@brianchandotcom, I had no time to write an integration test, but your changes look fine based on manual test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants