LPS-132871 ClassicEditor content is missing #102566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-132871-pr-1133-sender-markocikos-ts-1622541689732
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#1133 (Took 1
ci:forwardattempt in 1 minute)Console
@markocikos
@liferay-frontend
Original pull request comment:
Fixes: https://issues.liferay.com/browse/LPS-132871
@boton @julien
This is a bugfix, but basically a followup on liferay-frontend#954. The bug was caused by liferay-frontend@84432f7, merged as a part of that PR. Looking at the discussion in the PR, I see you wanted to use
dataprop, expecting that React component does the updating. But, you were looking atckeditor4-reactmaster and we are using an older version of React component in DXP. If you tried it, we would show unformatted code (see 1.3.0 gif).In this PR, we are updating
ckeditor4-reactto the latest version and usingdataparam to set content.Important note @boton : With this PR, it is likely that we will have regression on https://issues.liferay.com/browse/LPS-130112.
onChangeis now be triggered internally and we cannot avoid it. I am not sure now to replicate the issue in that ticket, or if it's still valid. We should probably find a different way to work around, because we don't want to be stuck with old version ofckeditor4-reactforever. Can you please look into this?Before PR:
After using
dataprop, withoutckeditor4-reactupdate:After this PR:
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 028f6fdc16f6cf3eccb5326b3ce4243a62c0f9ba
Sender Branch:
Branch Name: LPS-132871
1 out of 1jobs PASSEDBranch GIT ID: 1527d266dfe25bd1d75de8ba5a64016617eb13dc
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 23 out of 23 jobs passed in 3 hours 36 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 028f6fdc16f6cf3eccb5326b3ce4243a62c0f9ba
Upstream Comparison:
Branch GIT ID: 028f6fdc16f6cf3eccb5326b3ce4243a62c0f9ba
Jenkins Build URL: Acceptance Upstream DXP (master) #1919
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.
Test bundle downloads: