LPS-138941 Support doc links in configuration forms #107005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to allow contributing a doc link for a configuration
…y learn attributes are set
|
Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery. |
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
Very nice @pei-jung ! |
liferay-continuous-integration
deleted the
ci-forward-LPS-138941-pr-260-sender-pei-jung-ts-1631307745735
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: https://github.com/liferay-usm/liferay-portal/pull/260 (Took 1
ci:forwardattempt in 2 minutes)Console
@pei-jung
@liferay-usm
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: c406508139ee68d8938a2076c9afa7e56bb47b38
Sender Branch:
Branch Name: LPS-138941
1 out of 1jobs PASSEDBranch GIT ID: 7ec2a682118cee5d44c500b5225cd1c1969a5f72
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 10 out of 10 jobs passed
✔️ ci:test:relevant - 21 out of 22 jobs passed in 1 hour 53 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: c406508139ee68d8938a2076c9afa7e56bb47b38
Upstream Comparison:
Branch GIT ID: c406508139ee68d8938a2076c9afa7e56bb47b38
Jenkins Build URL: Acceptance Upstream DXP (master) #2309
ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED
2 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/020 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at c406508:
test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
652 Tests Passed.
1 Test Failed.