Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-138610 Fix Sidebar spacing when A11y Panel is open #109089

Closed
wants to merge 1 commit into from
Closed

LPS-138610 Fix Sidebar spacing when A11y Panel is open #109089

wants to merge 1 commit into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-frontend#1602 (Took 1 ci:forward attempt in 1 minute)
Console

@matuzalemsteles
@liferay-frontend

Original pull request comment:
This fixes the spacing of Sidebars that are fixed or absolutes when the a11y tool is enabled and the Panel is rendered, this is a solution that needs to be added in every sidebar that has in DXP that doesn't follow a specific markup.

I can't think of another way to be able to position the A11y Panel with CSS only and move away the other sidebars that are open on the same side in a less hardcoded way. I'm accepting any suggestion for this!

Before After
image Screen Shot 2021-10-22 at 16 54 11

Steps to Reproduce:

  • Add nodejs.node.env=development in build.${computer.name}.properties
    Create a com.liferay.frontend.js.a11y.web.internal.configuration.FFA11yConfiguration.config file containing enable=B"true" in osgi/configs
  • Sign in with test
  • Navigate to Site Builder -> Pages -> create Public Widget Page
  • Navigate to widget page
  • Click on "+" to add widgets

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576

Sender Branch:

Branch Name: LPS-138610
Branch GIT ID: 31911e289ba6f59eaa1dc354a639be0f5559e082

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576

Upstream Comparison:

Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576
Jenkins Build URL: Acceptance Upstream DXP (master) #2484

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 25 out of 27 jobs PASSED
25 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0dc4a52:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    502 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #12415
      1. com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/portal-vulcan/portal-vulcan-api]
        java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.portal.vulcan.openapi                  MAJOR      1.2.0      1.2.0      2.0.0      VERSION INCREASE REQUIRED
	>   class      com.liferay.portal.vulcan.openapi.DTOProperty
		-   method     <init>(java.lang.String,java.lang.String)
			-   return     void
		+   method     <init>(java.util.Map,java.lang.String,java.lang.String)
			+   return     void
		+   method     getExtensions()
			+   return     java.util.Map
[Baseline Warning] Bundle Version Change Recommended: 10.0.0

        at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning(SemanticVersioningTest.java:82)
at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html><h5>Test bundle downloads:</h5><ul><li><a href="https://files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">liferay-portal-bundle-tomcat.tar.gz</a> (mirrors: <a href="http://mirrors.dlc.liferay.com/files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">dlc</a>, <a href="http://mirrors.lax.liferay.com/files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">lax</a>)</li></ul>

Closed
@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 56ab82f...3e2b2ce

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-138610-pr-1602-sender-matuzalemsteles-ts-1635272442208 branch November 3, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@liferay-continuous-integration @brianchandotcom @matuzalemsteles