LPS-138610 Fix Sidebar spacing when A11y Panel is open #1602

matuzalemsteles · 2021-10-22T19:56:44Z

This fixes the spacing of Sidebars that are fixed or absolutes when the a11y tool is enabled and the Panel is rendered, this is a solution that needs to be added in every sidebar that has in DXP that doesn't follow a specific markup.

I can't think of another way to be able to position the A11y Panel with CSS only and move away the other sidebars that are open on the same side in a less hardcoded way. I'm accepting any suggestion for this!

Before	After

Steps to Reproduce:

Add nodejs.node.env=development in build.${computer.name}.properties
Create a com.liferay.frontend.js.a11y.web.internal.configuration.FFA11yConfiguration.config file containing enable=B"true" in osgi/configs
Sign in with test
Navigate to Site Builder -> Pages -> create Public Widget Page
Navigate to widget page
Click on "+" to add widgets

liferay-continuous-integration · 2021-10-22T19:56:47Z

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

liferay-continuous-integration · 2021-10-22T19:56:49Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

matuzalemsteles · 2021-10-22T19:57:20Z

cc @john-co

liferay-continuous-integration · 2021-10-22T20:00:46Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576

Sender Branch:

Branch Name: LPS-138610
Branch GIT ID: 31911e289ba6f59eaa1dc354a639be0f5559e082

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-10-22T20:02:31Z

Jenkins Build:test-portal-source-format#825

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#1602

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - matuzalemsteles > liferay-frontend - PR#1602 - 2021-10-22[12:57:06]

Testray Importer:publish-testray-report#2723

liferay-continuous-integration · 2021-10-22T21:32:09Z

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 25 out of 27 jobs passed in 1 hour 34 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1317401_917

Base Branch:

Branch Name: master
Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576

Upstream Comparison:

Branch GIT ID: dd9364f2d9fa74cbb64b68d8948ac98d847be707
Jenkins Build URL: Acceptance Upstream DXP (master) #2483

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 25 out of 27 jobs PASSED

2 Failed Jobs:

25 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

502 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #5930

com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/portal-vulcan/portal-vulcan-api]

java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.portal.vulcan.openapi                  MAJOR      1.2.0      1.2.0      2.0.0      VERSION INCREASE REQUIRED
	>   class      com.liferay.portal.vulcan.openapi.DTOProperty
		-   method     <init>(java.lang.String,java.lang.String)
			-   return     void
		+   method     <init>(java.util.Map,java.lang.String,java.lang.String)
			+   return     void
		+   method     getExtensions()
			+   return     java.util.Map
[Baseline Warning] Bundle Version Change Recommended: 10.0.0
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning(SemanticVersioningTest.java:82)
at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements...</code></pre></div></li></ol></div></li></ol></div></li></ol><h4>For upstream results, click <a href="https://test-1-1.liferay.com/job/test-portal-acceptance-upstream-dxp(master)">here</a>.</h4></details></html><h5>Test bundle downloads:</h5><ul><li><a href="https://files.liferay.com/private/bundles/test-1-31/jobs/test-portal-acceptance-pullrequest(master)/builds/917/liferay-portal-bundle-tomcat.tar.gz">liferay-portal-bundle-tomcat.tar.gz</a> (mirrors: <a href="http://mirrors.dlc.liferay.com/files.liferay.com/private/bundles/test-1-31/jobs/test-portal-acceptance-pullrequest(master)/builds/917/liferay-portal-bundle-tomcat.tar.gz">dlc</a>, <a href="http://mirrors.lax.liferay.com/files.liferay.com/private/bundles/test-1-31/jobs/test-portal-acceptance-pullrequest(master)/builds/917/liferay-portal-bundle-tomcat.tar.gz">lax</a>)</li></ul>

john-co · 2021-10-22T22:59:05Z

ci:test:relevant

john-co · 2021-10-22T22:59:34Z

modules-semantic-versioning-jdk8/0 does not look related

liferay-continuous-integration · 2021-10-23T00:32:23Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576

Upstream Comparison:

Branch GIT ID: 0dc4a5217f3f2f32e640abe9829c0fb440f76576
Jenkins Build URL: Acceptance Upstream DXP (master) #2484

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 25 out of 27 jobs PASSED

2 Failed Jobs:

25 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0dc4a52:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

502 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #12415

com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/portal-vulcan/portal-vulcan-api]

java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.portal.vulcan.openapi                  MAJOR      1.2.0      1.2.0      2.0.0      VERSION INCREASE REQUIRED
	>   class      com.liferay.portal.vulcan.openapi.DTOProperty
		-   method     <init>(java.lang.String,java.lang.String)
			-   return     void
		+   method     <init>(java.util.Map,java.lang.String,java.lang.String)
			+   return     void
		+   method     getExtensions()
			+   return     java.util.Map
[Baseline Warning] Bundle Version Change Recommended: 10.0.0
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning(SemanticVersioningTest.java:82)
at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html><h5>Test bundle downloads:</h5><ul><li><a href="https://files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">liferay-portal-bundle-tomcat.tar.gz</a> (mirrors: <a href="http://mirrors.dlc.liferay.com/files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">dlc</a>, <a href="http://mirrors.lax.liferay.com/files.liferay.com/private/bundles/test-1-32/jobs/test-portal-acceptance-pullrequest(master)/builds/851/liferay-portal-bundle-tomcat.tar.gz">lax</a>)</li></ul>

matuzalemsteles · 2021-10-26T18:19:43Z

ci:forward

liferay-continuous-integration · 2021-10-26T18:19:47Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-10-26T18:19:48Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-10-26T18:20:41Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-10-26T18:20:54Z

Pull request has been successfully forwarded to brianchandotcom#109089
Console

LPS-138610 Fix Sidebar spacing when A11y Panel is open

31911e2

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 22, 2021

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 22, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Oct 22, 2021

matuzalemsteles added s-clay Pull requests to be reviewed by Clay Squad s-dxp One of the DXP squads should review this pull request (deprecated) labels Oct 25, 2021

liferay-continuous-integration mentioned this pull request Oct 26, 2021

LPS-138610 Fix Sidebar spacing when A11y Panel is open brianchandotcom/liferay-portal#109089

Closed

liferay-continuous-integration closed this Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-138610 Fix Sidebar spacing when A11y Panel is open #1602

LPS-138610 Fix Sidebar spacing when A11y Panel is open #1602

matuzalemsteles commented Oct 22, 2021 •

edited

liferay-continuous-integration commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

matuzalemsteles commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

john-co commented Oct 22, 2021

john-co commented Oct 22, 2021

liferay-continuous-integration commented Oct 23, 2021

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

matuzalemsteles commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

LPS-138610 Fix Sidebar spacing when A11y Panel is open #1602

LPS-138610 Fix Sidebar spacing when A11y Panel is open #1602

Conversation

matuzalemsteles commented Oct 22, 2021 • edited

Steps to Reproduce:

liferay-continuous-integration commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

matuzalemsteles commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 22, 2021

liferay-continuous-integration commented Oct 22, 2021

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 25 out of 27 jobs passed in 1 hour 34 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

john-co commented Oct 22, 2021

john-co commented Oct 22, 2021

liferay-continuous-integration commented Oct 23, 2021

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 32 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

matuzalemsteles commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

liferay-continuous-integration commented Oct 26, 2021

matuzalemsteles commented Oct 22, 2021 •

edited