Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it #112041

Closed
wants to merge 1 commit into from
Closed

[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it #112041

wants to merge 1 commit into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-echo#6883 (Took 1 ci:forward attempt in 1 minute)
Console

@bakayattila
@liferay-echo

Original pull request comment:
Hi Team,
Could you please review this pull request?

https://issues.liferay.com/browse/LPS-144086

Thank you!

I Inverted the logic of the viewSingleAsset parameter in the JSPs. From now in the parameter is by default true and set for false when necessary this way the canonical URLs will not show the "view >>" link and will reduce the appearance of the parameter in the URL as well.

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b

Upstream Comparison:

Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b
Jenkins Build URL: Acceptance Upstream DXP (master) #2781

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 28 out of 32 jobs PASSED
28 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 95cd65c:
  2. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0 #21775
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1641576004913.log:
!SESSION 2022-01-07 17:20:29.036 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.site.initializer.extender 4 0 2022-01-07 17:20:29.036
        
!MESSAGE FrameworkEvent ERROR
        
!STACK 0
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [724]
        
Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        

        at com.lifer...
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
FrameworkEvent ERROR
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [724]
        
Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        
at java.nio.file.Files.walkFileTree(Files.java:2670)
        
at java.nio.file.Files.walkFileTree(Files.java:2742)
        
at com.liferay.portal.log.asser...
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    2697 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=6 #479989
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
JSON storage adapter is deprecated, using default storage adapter
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        
at java.nio.file.Files.walkFileTree(Files.java:2670)
        
at java.nio.file.Files.walkFileTree(Files.java:2742)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
    2. AXIS_VARIABLE=7 #479989
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        
at java.nio.file.Files.walkFileTree(Files.java:2670)
        
at java.nio.file.Files.walkFileTree(Files.java:2742)
        
at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b

Sender Branch:

Branch Name: LPS-144086
Branch GIT ID: d45dba49f2d49093001ef05ccedaec1cecd060e6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

Closed
@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: d94b0af...020a435

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-144086-pr-6883-sender-bakayattila-ts-1641997533286 branch January 20, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@liferay-continuous-integration @brianchandotcom @bakayattila