[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it #6883

bakayattila · 2022-01-07T15:57:54Z

Hi Team,
Could you please review this pull request?

https://issues.liferay.com/browse/LPS-144086

Thank you!

I Inverted the logic of the viewSingleAsset parameter in the JSPs. From now in the parameter is by default true and set for false when necessary this way the canonical URLs will not show the "view >>" link and will reduce the appearance of the parameter in the URL as well.

…s necessary

liferay-continuous-integration · 2022-01-07T15:57:57Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

bakayattila · 2022-01-07T15:58:27Z

ci:test:sf

bakayattila · 2022-01-07T15:58:34Z

ci:test:relevant

bakayattila · 2022-01-07T15:58:42Z

ci:test:echo

liferay-continuous-integration · 2022-01-07T16:01:18Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b

Sender Branch:

Branch Name: LPS-144086
Branch GIT ID: d45dba49f2d49093001ef05ccedaec1cecd060e6

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-01-07T16:02:45Z

Jenkins Build:test-portal-source-format#1407

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#6883

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - bakayattila > liferay-echo - PR#6883 - 2022-01-07[07:58:38]

Testray Importer:publish-testray-report#4713

liferay-continuous-integration · 2022-01-07T17:39:22Z

❌ ci:test:echo - 17 out of 22 jobs passed in 1 hour 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b

Upstream Comparison:

Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b
Jenkins Build URL: Acceptance Upstream DXP (master) #2781

ci:test:echo - 17 out of 22 jobs PASSED

5 Failed Jobs:

17 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/5

Job Results:

23 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=2 #16602

start-docker-containers:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/docker_stop.sh
     [exec] 09461cb879430cffadec167ba5f9a65e77125546d0b39573433d916309e8b02d
     [exec] Started container [ID: '09461cb87943', name: 'test-1-33-3.lax.liferay.com_mysql'] from image 'mysql:5.7.25'
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/docker_start.sh
     [exec] Waiting for MySQL 5.7 to be ready
[stopwatch] [run.batch.test.action: 2.073 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:374: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13826: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4977: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5990: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:328: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 137
      [get] Getting: http://test-1-33/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=2/16602//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220107084620483.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220107084620483.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1275101407.properties

AXIS_VARIABLE=5 #16602
1. LocalFile.DisplayPageTemplates#ViewPreviewDraftViaURLFromNonAuthor - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13
Job Results:
61 Tests Passed.
5 Tests Failed.
Click here for more failures.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/7
Job Results:
89 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=12 #26586
  1. LocalFile.LocalizationWithWebContent#AddWCWithMultipleTranslations - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

3897 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=9 #348426

com.liferay.portal.fragment.bundle.watcher.test.PortalFragmentBundleWatcherTest.testDeployTwoFragmentsAndUnrelatedBundlesSimultaneously

java.lang.AssertionError: Thread Thread[Refresh Thread: Equinox Container: 669d2c43-e014-42b4-9fb0-57d8064fd7dd,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.lpkg.deployer.internal.LPKGBundleTrackerCustomizer, message=Unable to determine if LPKG com.liferay.portal.fragment.bundle.watcher.test.host.fragment.b_1.0.0 [1404] is outdated
java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.lpkg.deployer.internal.LPKGBundleTrackerCustomizer, message=Unable to determine if LPKG com.liferay.portal.fragment.bundle.watcher.test.host.fragment.b_1.0.0 [1404] is outdated
  at com.liferay.portal.test.rule.LogAssertionTestRule$LogAppender.append(LogAssertionTestRule.java:330)
  at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161)
  at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134)
  at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125)
  at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89)
  at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:542)
  at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:500)
  at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483)
  at org.apache.logging.log4j.core.config.LoggerConfig.logParent(LoggerConfig.java:53...

Failures in common with acceptance upstream results at 95cd65c:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/7
Job Results:
89 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=22 #26586
  1. LocalFile.MastersPageTemplates#PropagateChangesFromCustomMastersToAllBasedOnCustomMasters - Poshi Report - Poshi Summary - Console Output
...

liferay-continuous-integration · 2022-01-07T17:52:14Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b

Upstream Comparison:

Branch GIT ID: 95cd65c26c2291146d4f02bf1c6a50c34d11f49b
Jenkins Build URL: Acceptance Upstream DXP (master) #2781

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 28 out of 32 jobs PASSED

4 Failed Jobs:

28 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 95cd65c:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4
Job Results:
127 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=23 #5412
  1. LocalFile.MastersPageTemplates#PropagateChangesFromCustomMastersToAllBasedOnCustomMasters - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

3 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0 #21775

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1641576004913.log: !SESSION 2022-01-07 17:20:29.036 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US !ENTRY com.liferay.site.initializer.extender 4 0 2022-01-07 17:20:29.036 !MESSAGE FrameworkEvent ERROR !STACK 0 org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [724] Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.lifer...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: FrameworkEvent ERROR org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [724] Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at com.liferay.portal.log.asser...

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

2697 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=6 #479989

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

JSON storage adapter is deprecated, using default storage adapter

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

AXIS_VARIABLE=7 #479989

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2022-01-07T17:53:26Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1551

Jenkins Report:jenkins-report.html

Jenkins Suite:echo

Pull Request:liferay-echo#6883

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:echo - bakayattila > liferay-echo - PR#6883 - 2022-01-07[07:58:53]

Testray Importer:publish-testray-report#4714

liferay-continuous-integration · 2022-01-07T17:57:49Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1550

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#6883

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bakayattila > liferay-echo - PR#6883 - 2022-01-07[07:58:46]

Testray Importer:publish-testray-report#4715

Tim-Cao · 2022-01-11T01:31:46Z

Hi @bakayattila and @ealonso, no regression issues found according to ci:test:echo

ruben-pulido · 2022-01-11T14:57:44Z

Just started reviewing :)

ruben-pulido · 2022-01-12T13:14:08Z

Just started reviewing :)

ruben-pulido · 2022-01-12T14:24:19Z

ci:forward

liferay-continuous-integration · 2022-01-12T14:24:23Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-01-12T14:24:24Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-01-12T14:25:32Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-01-12T14:25:43Z

Pull request has been successfully forwarded to brianchandotcom#112041
Console

LPS-144086 Inverting the logic of the parameter to only add when it i…

d45dba4

…s necessary

liferay-continuous-integration added ci:test:sf - pending ci:test:echo - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 7, 2022

liferay-continuous-integration added ci:test:echo - failure and removed ci:test:echo - pending labels Jan 7, 2022

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 7, 2022

ealonso added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Jan 10, 2022

ruben-pulido self-assigned this Jan 11, 2022

ruben-pulido added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. labels Jan 12, 2022

liferay-continuous-integration mentioned this pull request Jan 12, 2022

[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it brianchandotcom/liferay-portal#112041

Closed

liferay-continuous-integration closed this Jan 12, 2022

[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it #6883

[TS] LPS-144086 | "View" button appeared in the Asset Publisher when using URL to reach it #6883

Conversation

bakayattila commented Jan 7, 2022

liferay-continuous-integration commented Jan 7, 2022

bakayattila commented Jan 7, 2022

bakayattila commented Jan 7, 2022

bakayattila commented Jan 7, 2022

liferay-continuous-integration commented Jan 7, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 7, 2022

liferay-continuous-integration commented Jan 7, 2022

❌ ci:test:echo - 17 out of 22 jobs passed in 1 hour 40 minutes

Base Branch:

Upstream Comparison:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Jan 7, 2022

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 52 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Jan 7, 2022

liferay-continuous-integration commented Jan 7, 2022

Tim-Cao commented Jan 11, 2022

ruben-pulido commented Jan 11, 2022

ruben-pulido commented Jan 12, 2022

ruben-pulido commented Jan 12, 2022

liferay-continuous-integration commented Jan 12, 2022

liferay-continuous-integration commented Jan 12, 2022

liferay-continuous-integration commented Jan 12, 2022

liferay-continuous-integration commented Jan 12, 2022