LPS-152229 Replace and deprecate listSelect with new getSelectedOptionValues utility
#117395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-listSelect-pr-2199-sender-kresimir-coko-ts-1652430004205
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#2199 (Took 1
ci:forwardattempt in 1 minute)Console
@kresimir-coko
@liferay-frontend
Original pull request comment:
Overview
listSelectis a utility that accepts a<select>element, and an optionaldelimiterargument. It returns a CSV string consisting of values of<option>elements that are children of the<select>element.I've decided to rename this utility as it doesn't do what the name
listSelectsuggests but instead it gets the selected options inside the provided select element.馃И This util can be tested by dragging the
Documents & Mediaportlet onto the landing page and going to its Configuration. Once there, click Save and the util will be invoked.Previous
ci:test:relevantbuild was successfully reevaluated against more recent upstream results.鉁旓笍 ci:test:stable - 25 out of 25 jobs passed
鉁旓笍 ci:test:relevant - 266 out of 286 jobs passed in 2 hours 28 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: d5d3a9d5e7a6275cf170dfcc43ef68d63fb7009b
Upstream Comparison:
Branch GIT ID: d5d3a9d5e7a6275cf170dfcc43ef68d63fb7009b
Jenkins Build URL: Acceptance Upstream DXP (master) #3260
ci:test:stable - 25 out of 25 jobs PASSED
25 Successful Jobs:
ci:test:relevant - 265 out of 286 jobs PASSED
21 Failed Jobs:
test-portal-acceptance-pullrequest(master)functional-tomcat90-mysql57-jdk8/1/7functional-tomcat90-mysql57-jdk8/1/9functional-tomcat90-mysql57-jdk8/2/2functional-tomcat90-mysql57-jdk8/2/11functional-tomcat90-mysql57-jdk8/2/15functional-tomcat90-mysql57-jdk8/2/16functional-tomcat90-mysql57-jdk8/2/17functional-tomcat90-mysql57-jdk8/3/2functional-tomcat90-mysql57-jdk8/4/23functional-tomcat90-mysql57-jdk8/6/18functional-tomcat90-mysql57-jdk8/7/4functional-tomcat90-mysql57-jdk8/7/5functional-tomcat90-mysql57-jdk8/7/6modules-integration-mysql57-jdk8/0/13modules-integration-mysql57-jdk8/0/14modules-integration-mysql57-jdk8/0/15modules-integration-mysql57-jdk8/0/16modules-integration-mysql57-jdk8/0/17modules-integration-mysql57-jdk8/0/19modules-integration-mysql57-jdk8/0/21265 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at d5d3a9d:
鉁旓笍 ci:test:sf - 1 out of 1 jobs passed in 5 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: d5d3a9d5e7a6275cf170dfcc43ef68d63fb7009b
Sender Branch:
Branch Name: listSelect
1 out of 1jobs PASSEDBranch GIT ID: 6e662df86bd77fd134a4875959bb747d8c94f87d
1 Successful Jobs:
For more details click here.