Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-157511 Date field added from widget template does not allow manual enter of data in Modified Facet #120001

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-search#479 (Took 1 ci:forward attempt in 1 minute)
Console

@antonio-ortega
@liferay-search

Original pull request comment:
https://issues.liferay.com/browse/LPS-157511

Hi guys,

This restriction was added here, I guess to help validating dates, however preventing keyboard input makes really hard for end users to select dates far from today.

I've checked introducing data manually after this change and I can see how data is still being validated.

Let me know if you have further questions.

Thanks.

Regards.

✔️ ci:test:stable - 26 out of 27 jobs passed

✔️ ci:test:relevant - 57 out of 59 jobs passed in 1 hour 41 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 201a6bc713ba0c9e00a8b23ee4eb924e71e1cf08

Upstream Comparison:

Branch GIT ID: c21b7cf9d19d24489682fc305ecaccfc93d2a9f4
Jenkins Build URL: Acceptance Upstream DXP (master) #3509

ci:test:stable - 26 out of 27 jobs PASSED

1 Failed Jobs:

26 Successful Jobs:
ci:test:relevant - 56 out of 59 jobs PASSED

3 Failed Jobs:

56 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c21b7cf:
  1. central-requirements-jdk8/0/0
    1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
        at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
        at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
        at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
        at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
      
  2. modules-integration-mysql57-jdk8_stable/0/0
    1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
      junit.framework.AssertionFailedError: 
      null
      java.lang.NullPointerException
        at com.liferay.adaptive.media.image.internal.validator.AMImageValidatorImpl._isFileVersionStoredMetadataSupported(AMImageValidatorImpl.java:122)
        at com.liferay.adaptive.media.image.internal.validator.AMImageValidatorImpl.isValid(AMImageValidatorImpl.java:90)
        at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.cleanUp(AMImageProcessorImpl.java:55)
        at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.cleanUp(AMImageProcessorImpl.java:46)
        at com.liferay.adaptive.media.web.internal.messaging.AMProcessorCommand$1.execute(AMProcessorCommand.java:32)
        at com.liferay.adaptive.media.web.internal.messaging.AMMessageListener.doReceive(AMMessageListener.java:80)
        at com.liferay.portal.kernel.messaging.BaseMessageListener.doReceive(BaseMessageListener.java:48)
        at com.liferay.portal.kernel.messaging.BaseMessageListener.receive(BaseMessageListener.java:34)
        at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
        at com.liferay.portal.messaging.internal.ParallelDestination$1.run(ParallelDestination.java:56)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
      

      at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)...

Test bundle downloads:

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1fae5b2b07aada0bd6c6263e8f4345e9a5e8acc1

Sender Branch:

Branch Name: LPS-157511
Branch GIT ID: 0c30717fe434610ec260fd928d6ed6f95ab7ac59

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 90a2684...dee86ec

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-157511-pr-479-sender-antonio-ortega-ts-1657150397273 branch July 14, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants