Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-163590 - Update bundler and add package.json dependencies back in #124234

Closed

Conversation

bryceosterhaus
Copy link

@bryceosterhaus bryceosterhaus commented Oct 7, 2022

Manual Forward from: liferay-frontend#2753

@brianchandotcom, follow the PR conversation to see discussion on build time performance from this PR.

tldr;

After a git clean -fdx, master was a little more than 1 minute faster
Without Gradle cache only, master was 24s faster
With all caches, master was 5s slower

Build times slightly increase, although these times may have been impacted by network speeds and thus making the time difference negligible.

I believe there are additional FE improvements we can make to increase decrease the build times as well.

Additionally, by adding these dependencies back in, our typescript generation should become more accurate.

Let me know if you have any questions/concerns

https://issues.liferay.com/browse/LPS-163590

@liferay-continuous-integration
Copy link
Collaborator

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

@bryceosterhaus
Copy link
Author

ci:reopen

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 010ecda...b168c93

@brianchandotcom
Copy link
Owner

Thx @bryceosterhaus

@natocesarrego fyi!

@ling-alan-huang we can probably remove JSONPackageJSONRedundantDependenciesCheck if the code here works and the paradigm has changed.

@natocesarrego
Copy link

Thanks for lettting me know, @brianchandotcom! 🙂

The build times shared by @bryceosterhaus were extracted on my machine by the script created by you, the ant_all_benchmark.sh. @bryceosterhaus shared this pull with me a few days ago. 😄

Thanks everybody!

@bryceosterhaus
Copy link
Author

I additionally created this issue to investigate some other build time impacts from our frontend toolset, liferay/liferay-frontend-projects#1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants