LPS-163590 - Update bundler and add package.json dependencies back in #2753

bryceosterhaus · 2022-09-28T10:55:19Z

https://issues.liferay.com/browse/LPS-163590

We previously declared all dependencies in package.json files but then realized this was causing significant slow down in build times because we were re-bundling dependencies that were already provided to the platform. So with this change, we now look to the global npmscripts.config.js for the bundler config and only bundle the dependency if it isn't already provided by another module.

With this change, we can disable and remove the SF rule that removed all of the package.json dependencies.

cc @ling-alan-huang please take a look at this and see if I need to do anything else with the SF rule.

cc @natocesarrego since you originally discoevered the slow down of build times, could you verify here that by adding back in dependencies that we aren't slowing down the build times again? I tested it myself and it was consistent with current master builds, but just want you to verify as well in case you have more sophisticated tools for checking build speeds.

liferay-continuous-integration · 2022-09-28T10:55:25Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-09-28T11:14:04Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 18 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3dee1e05c515c818691155b2b007112c61561725

Sender Branch:

Branch Name: LPS-163590
Branch GIT ID: 83f7d6bd078d6e793942d20265c70a35b53dd2c7

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-09-28T11:17:23Z

Jenkins Build:test-portal-source-format#3440

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#2753

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - bryceosterhaus > liferay-frontend - PR#2753 - 2022-09-28[03:55:49]

Testray Importer:publish-testray-report#12646

izaera · 2022-09-28T11:45:31Z

👌

kresimir-coko · 2022-09-28T11:50:16Z

Does this PR mean I would have to add frontend-js-web to the list of dependencies if a module starts using one of our utils? Namely talking about the #2701 PR where there are possibly a couple of modules that are importing a util but aren't specifying the dependency in package.json.

These occurrences are rare if they even exist, but I think we should be careful about merging either without coordinating.

liferay-continuous-integration · 2022-09-28T15:53:38Z

❌ ci:test:stable - 25 out of 28 jobs passed

❌ ci:test:relevant - 982 out of 1093 jobs passed in 4 hours 34 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1277401_5184

Base Branch:

Branch Name: master
Branch GIT ID: 3dee1e05c515c818691155b2b007112c61561725

Upstream Comparison:

Branch GIT ID: f607bcfea15e7007901d9282b30b016f1e861b7c
Jenkins Build URL: EE Development Acceptance (master) - 3848 - 2022-09-28[00:13:24]

ci:test:stable - 25 out of 28 jobs PASSED

3 Failed Jobs:

central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
js-unit-jdk8
- ~~js-unit-jdk8/0/0~~
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-jdk8
- ~~portal-license-smoke-jdk8/0/0~~
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0

25 Successful Jobs:

ci:test:relevant - 982 out of 1093 jobs PASSED

111 Failed Jobs:

982 Successful Jobs:

For more details click here.

Failures unique to this pull:

js-unit-jdk8/0/0

     [exec] * What went wrong:
     [exec] Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)

empty-temp-dir-jdk8/0/0

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to register portal instance {"mvccVersion": 1, "companyId": 20097, "userId": 0, "userName": "", "createDate": "Wed Sep 28 13:06:20 GMT 2022", "modifiedDate": "Wed Sep 28 13:06:20 GMT 2022", "webId": "liferay.com", "mx": "liferay.com", "homeURL": "", "logoId": 0, "maxUsers": 0, "active": true, "name": "Liferay", "legalName": "", "legalId": "", "legalType": "", "sicCode": "", "tickerSymbol": "", "industry": "", "type": "", "size": ""}
com.liferay.portal.kernel.repository.UndeployedExternalRepositoryException: Unable to load external repository class com.liferay.portal.repository.liferayrepository.LiferayRepository because its plugin is not deployed
  at com.liferay.portal.repository.RepositoryFactoryImpl.getRepositoryFactory(RepositoryFactoryImpl.java:72)
  at com.liferay.portal.repository.RepositoryFactoryImpl.createLocalRepository(RepositoryFactoryImpl.java:39)
  at com.liferay.portal.repository.RepositoryProviderImpl.getLocalRepository(RepositoryProviderImpl.java:268)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.getLocalRepository(DLAppLocalServiceImpl.java:1490)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.fetchFileEntryByExternalReferenceCode(DLAppLocalServiceImpl.java:572)
  at com.liferay.portal.kernel.bean.ClassLoaderBeanHandler.invoke(ClassLoaderBeanHandler.java:66)
  at com.sun.proxy.$Proxy969.fetchFileEntryByExternalReferenceCode(Unknown Source)
  at com.liferay.doc...

functional-smoke-wildfly180-mariadb104-jdk8/0/0

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to register portal instance {"mvccVersion": 1, "companyId": 20097, "userId": 0, "userName": "", "createDate": "Wed Sep 28 13:24:57 GMT 2022", "modifiedDate": "Wed Sep 28 13:24:57 GMT 2022", "webId": "liferay.com", "mx": "liferay.com", "homeURL": "", "logoId": 0, "maxUsers": 0, "active": true, "name": "Liferay", "legalName": "", "legalId": "", "legalType": "", "sicCode": "", "tickerSymbol": "", "industry": "", "type": "", "size": ""}
com.liferay.portal.kernel.repository.UndeployedExternalRepositoryException: Unable to load external repository class com.liferay.portal.repository.liferayrepository.LiferayRepository because its plugin is not deployed
  at com.liferay.portal.repository.RepositoryFactoryImpl.getRepositoryFactory(RepositoryFactoryImpl.java:72)
  at com.liferay.portal.repository.RepositoryFactoryImpl.createLocalRepository(RepositoryFactoryImpl.java:39)
  at com.liferay.portal.repository.RepositoryProviderImpl.getLocalRepository(RepositoryProviderImpl.java:268)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.getLocalRepository(DLAppLocalServiceImpl.java:1490)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.fetchFileEntryByExternalReferenceCode(DLAppLocalServiceImpl.java:572)
  at com.liferay.portal.kernel.bean.ClassLoaderBeanHandler.invoke(ClassLoaderBeanHandler.java:66)
  at com.sun.proxy.$Proxy1014.fetchFileEntryByExternalReferenceCode(Unknown Source)
  at com.liferay.do...

LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

functional-tomcat90-mysql57-jdk8/0/22
1. LocalFile.SAML#AssertAuthorizationOnOAuth2WithSAMLConnectionWithExistingUser - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/1/11
1. LocalFile.StagingActivation#CheckPublicationSummaryRemote - Poshi Report - Poshi Summary - Console Output
...

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-09-28T16:11:54Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5184

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#2753

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bryceosterhaus > liferay-frontend - PR#2753 - 2022-09-28[04:16:23]

Testray Importer:publish-testray-report#12652

natocesarrego · 2022-09-28T16:19:41Z

Thank you very much for mentioning me, @bryceosterhaus! 🙂

I downloaded this branch to my machine and I'll compare its results against the master branch then I get back to you. In addition, just to let you know, I set the property gradle.profile.enabled=true in my build.properties in order to get more details about the build times. 🙂

bryceosterhaus · 2022-09-29T05:45:46Z

@kresimir-coko yeah going forward we would add all dependencies to package.json, including frontend-js-web. However, even if this PR gets merged and you forget to add frontend-js-web it will still work as it did before this PR. This just allows us to be more verbose in our dependency list. So I don't think it'll bring any issues with it

natocesarrego · 2022-09-29T14:05:02Z

Hi @bryceosterhaus,

I ran ant all using master and a branch with master + LPS-163590 and the results demonstrated that master compile is faster without LPS-163590. I compiled each branch 3 times between yesterday and today and, in all times, master was faster. My last run was executing just ant all, e.g. all other programs were closed, even though master was 14 seconds faster. It's important to emphasize that this last run had all local caches already created. In a scenario in which I compiled portal using other softwares, like browser and Slack, I experienced a considerable difference of time, master was approximately 7 minutes faster than master + LPS-163590.

All results mentioned above are based on data extracted using the property gradle.profile.enabled=true in the build.properties. Basically, this property tells Gradle to measure the time consumed to run each of its tasks. It's also important to say that these measures are related just to the modules placed inside the folder modules. Please, check the results here.

A few months ago, Brian Chan created a script to measure ant all speed in different scenarios, therefore I'll also run it locally and then share its results here too. 🙂

Thanks

natocesarrego · 2022-09-29T22:26:03Z

Hi @bryceosterhaus,

I just finished to run the script created by Brian and I realized the following:

After a git clean -fdx, master was a little more than 1 minute faster
Without Gradle cache only, master was 24s faster
With all caches, master was 5s slower

Please check the evidences below:

Sorry about the quality of the images, but I've had some issues to take screen shots. 😁

Therefore, the impact of merging the LPS-163590 will be realized only when there are no caches available on the machine running ant all.

@bryceosterhaus, feel free to share this analysis with Brian if he asks about perfomance decrease related to this pull request.

Thanks

bryceosterhaus · 2022-09-30T12:20:14Z

@natocesarrego thanks so much for the detailed report! So just to be clear, the worst case scenario you are seeing is

After a git clean -fdx, master was a little more than 1 minute faster

Am I correct in seeing that?

For this point

In a scenario in which I compiled portal using other softwares, like browser and Slack, I experienced a considerable difference of time, master was approximately 7 minutes faster than master + LPS-163590.

That seems like a really large separation, especially when considered against your other tests. Do you think the 7 minute difference is really due to my changes or do you think it stems from the other processes that were going on?

I will use your info and continue to look into this next week and hopefully can get this PR more in line with master's build times

natocesarrego · 2022-09-30T17:36:56Z

Hi @bryceosterhaus,

Answering your questions:

Am I correct in seeing that?

Yes

That seems like a really large separation, especially when considered against your other tests. Do you think the 7 minute difference is really due to my changes or do you think it stems from the other processes that were going on?

Honestly, I don't think your proposed changes are causing the 7 minutes delay, probably, it might be caused by a high load in the network traffic. IMHO, we can consider my latest runs as a performance analysis. Even though, I believe that it worth take a look on the reports mentioned here, since they can assist us identify the biggest build time offenders. 🙂

Thanks for your partnership!

izaera · 2022-10-04T05:51:23Z

Just wanted to note some things about the tests...

8 seconds out of 8 minutes is small enough to be a normal deviation
The tests should be run without any other user interaction in the system, since that tends to make times much faster and deviate a lot from the mean.
If we wanted to do this correctly (statistically speaking) at the very least we should run several ant alls with and without the LPS and make an statistical check (eg: https://online.stat.psu.edu/statprogram/reviews/statistical-concepts/hypothesis-testing/p-value-approach) of both data sets to see if the difference is significant. We may also want to check the statistical power of the experiment (https://www.scribbr.com/statistics/statistical-power/).

3 may sound overkill but it's the only correct way to check these things 🤷

Note that I admit that I haven't done it that way either when I've made performance changes, but maybe we should start doing it 🤔 In the end, we are talking about hundreds of machines running ant all every day...

bryceosterhaus · 2022-10-04T06:18:56Z

8 seconds out of 8 minutes is small enough to be a normal deviation

Yeah I agree, 8 seconds seems pretty negligible compared to 8min.

The tests should be run without any other user interaction in the system, since that tends to make times much faster and deviate a lot from the mean.

I am getting a VM for running nightly performance tests, and one thing we could also add on that machine is testing how long the bundle process takes in DXP. That way we could track larger deviations. The nightly performance checks should only be run once or twice a day, so we can utilize the other machine time with build times for our FE tools.

If we wanted to do this correctly (statistically speaking) at the very least we should run several ant alls with and without the LPS and make an statistical check (eg: https://online.stat.psu.edu/statprogram/reviews/statistical-concepts/hypothesis-testing/p-value-approach) of both data sets to see if the difference is significant. We may also want to check the statistical power of the experiment (https://www.scribbr.com/statistics/statistical-power/).

I've run some tests to iterate several ant all's and log the times, but the deviation between runs(both master and the LPS) could be upwards of 3-4 minutes, so I couldn't ever get anything conclusive for comparing before/after. I suspect I would need to run this in a more efficient machine without any other process going on.

bryceosterhaus · 2022-10-05T06:05:37Z

ci:test:sf

bryceosterhaus · 2022-10-05T06:05:44Z

ci:test:relevant

bryceosterhaus · 2022-10-07T07:59:33Z

ci:test:sf

bryceosterhaus · 2022-10-07T08:00:49Z

Because this PR touches pretty much every module and triggers so many tests in portal, I think it makes sense to forward to BChan once SF is green. The previous unique failure seemed to be flakey, as it passed locally for me.

liferay-continuous-integration · 2022-10-07T08:23:35Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 23 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 410123945a2bd55e8d58aa8e0baf51cd2235e4d0

Sender Branch:

Branch Name: LPS-163590
Branch GIT ID: 1e239069c85788d3d2175109535f47ada6a30a23

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

bryceosterhaus · 2022-10-07T08:25:39Z

ci:test:relevant

bryceosterhaus · 2022-10-07T08:37:45Z

manual forward at brianchandotcom#124234

bryceosterhaus · 2022-10-07T08:40:55Z

I additionally spawned this issue, liferay/liferay-frontend-projects#1026 to investigate

liferay-continuous-integration · 2022-10-07T09:32:05Z

Jenkins Build:test-portal-source-format#520

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#2753

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - bryceosterhaus > liferay-frontend - PR#2753 - 2022-10-07[01:00:10]

Testray Importer:publish-testray-report#1611

liferay-continuous-integration · 2022-10-07T10:25:23Z

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 949 out of 1090 jobs passed in 3 hours 28 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1387401_4140

Base Branch:

Branch Name: master
Branch GIT ID: f38b8f8b5d34f78d0cd36ce61343d20bdda6786a

Upstream Comparison:

Branch GIT ID: 423c71617cdd3bc45a35237220c771b44c2962ec
Jenkins Build URL: EE Development Acceptance (master) - 3877 - 2022-10-06[17:38:25]

ci:test:stable - 27 out of 28 jobs PASSED

1 Failed Jobs:

central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
js-unit-jdk8
- ~~js-unit-jdk8/0/0~~
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-jdk8
- portal-license-smoke-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0

27 Successful Jobs:

ci:test:relevant - 949 out of 1090 jobs PASSED

141 Failed Jobs:

949 Successful Jobs:

For more details click here.

Failures unique to this pull:

js-unit-jdk8/0/0

     [exec] * What went wrong:
     [exec] Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)

modules-integration-mysql57-jdk8/2/4

A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

semantic-versioning-jdk8/0/0

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:commerce:commerce-product-service:jar'.
     [exec] > Bundle com.liferay.commerce.product.service-6.0.82.jar has errors
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:commerce:commerce-product-service:jar'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)

functional-tomcat90-mysql57-jdk8/5/15
1. LocalFile.BlogsNotifications#EmailIsReceivedWhenUpdateReachesScheduledTime - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/8/5
1. LocalFile.ClickToChatInstanceSettings#LivePersonCanBeEnabledAndDisabled - Poshi Report - Poshi Summary - Console Output
...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-10-07T10:53:24Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4140

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#2753

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bryceosterhaus > liferay-frontend - PR#2753 - 2022-10-06[23:47:12]

Testray Importer:publish-testray-report#9463

liferay-continuous-integration · 2022-10-07T12:42:32Z

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 955 out of 1090 jobs passed in 4 hours 14 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1297401_4924

Base Branch:

Branch Name: master
Branch GIT ID: 410123945a2bd55e8d58aa8e0baf51cd2235e4d0

Upstream Comparison:

Branch GIT ID: f38b8f8b5d34f78d0cd36ce61343d20bdda6786a
Jenkins Build URL: EE Development Acceptance (master) - 3878 - 2022-10-06[20:39:49]

ci:test:stable - 27 out of 28 jobs PASSED

1 Failed Jobs:

central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
js-unit-jdk8
- ~~js-unit-jdk8/0/0~~
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-jdk8
- portal-license-smoke-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0

27 Successful Jobs:

ci:test:relevant - 955 out of 1090 jobs PASSED

135 Failed Jobs:

955 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-upgrade-tomcat90-mysql57-jdk8/0/12

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
     [exec] 
     [exec] * Try:
     [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 15m 57s
     [exec] 4 actionable tasks: 3 executed, 1 up-to-date
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2022-10-07-05-17-46.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Result: 1
     [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/82777
     [copy] Copying 4 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/82777/screenshots
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null448250469.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null448250469.properties
clean-up-logs:

[echo] stop.app.server.0.start.timestamp: 10-07-2022 05:33:45:951 PDT

[parallel] 2022-10-07 12:34:15.113 INFO  [main][ThemeHotDeployListener:171] 1 theme for admin-theme was unregistered

[parallel] 2022-10-07 12:34:15.252 INFO  [main][ThemeHotDeployListener:171] 1 theme for speedwell-theme was unregistered

[parallel] 2022-10-07 12:34:17.807 INFO  [main][ThemeHotDeployListener:171] 1 theme for classic-theme was unregistered

[parallel] 2022-10-07 12:34:18.351 INFO  [main][ThemeHotDeployListener:171] 1 theme for minium-theme was unregistered

[parallel] 2022-10-07 12:34:19.219 INFO  [main][ThemeHotDeployListener:171] 1 theme for dialect-theme was unregistered

[stopwatch] [stop.app.server.0: 45.084 sec]

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null448250469.properties
run-poshi-evaluate-console:

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1402707098.properties
prepare-poshi-runner-properties:

js-unit-jdk8/0/0

     [exec] * What went wrong:

[exec] Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.

[exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1

[exec]

[exec] * Try:

[exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.

[exec]

[exec] * Exception is:

[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':dxp:apps:commerce:commerce-shop-by-diagram-web:packageRunTest'.

[exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)

[exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)

[exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)

[exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173)

[exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)

[exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)

[exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)

[exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)

[exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)

[exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)

[exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)

[exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)

[exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

[exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)

functional-tomcat90-mysql57-jdk8/26/18
1. LocalFile.ObjectPermission#CanEditItsOwnEntryWithOnlyAddPermission - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/26/22
1. LocalFile.ObjectPermission#CanViewItsOwnEntryWithOnlyAddPermission - Poshi Report - Poshi Summary - Console Output
functional-upgrade-tomcat90-mysql57-jdk8/0/13
1. LocalFile.WorkflowUpgrade#ViewAndApproveWorkflowBlogsAfterUpgrade621021 - Poshi Report - Poshi Summary - Console Output
...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-10-07T13:06:11Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4924

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#2753

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bryceosterhaus > liferay-frontend - PR#2753 - 2022-10-07[01:26:43]

Testray Importer:publish-testray-report#12466

john-co · 2022-10-11T16:10:18Z

~Reviewed. Test failures are unrelated. ✔️ ~

~~Ok to manually forward from QA perspective.~~

~~Testray Comparison~~

~~cc/ @gaborlovasdotcom @JoyceWang08211 Oauth2 tests look somewhat inconsistently failing.~~

~~cc/ @timpak ObjectPortlet#CannotViewOtherUsersEntryWithOnlyAddPermission is sporadically failing~~

Sorry, this analysis was meant for #2775

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Sep 28, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Sep 28, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Sep 28, 2022

bryceosterhaus force-pushed the LPS-163590 branch 2 times, most recently from bf0998c to 07821a7 Compare October 5, 2022 06:05

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - success labels Oct 5, 2022

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Oct 7, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 7, 2022

bryceosterhaus mentioned this pull request Oct 7, 2022

LPS-163590 - Update bundler and add package.json dependencies back in brianchandotcom/liferay-portal#124234

Closed

bryceosterhaus closed this Oct 7, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 7, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - failure ci:test:stable - failure labels Oct 7, 2022

LPS-163590 - Update bundler and add package.json dependencies back in #2753

LPS-163590 - Update bundler and add package.json dependencies back in #2753

Conversation

bryceosterhaus commented Sep 28, 2022

liferay-continuous-integration commented Sep 28, 2022

liferay-continuous-integration commented Sep 28, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 18 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 28, 2022

izaera commented Sep 28, 2022

kresimir-coko commented Sep 28, 2022

liferay-continuous-integration commented Sep 28, 2022

❌ ci:test:stable - 25 out of 28 jobs passed

❌ ci:test:relevant - 982 out of 1093 jobs passed in 4 hours 34 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

111 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-continuous-integration commented Sep 28, 2022

natocesarrego commented Sep 28, 2022

bryceosterhaus commented Sep 29, 2022

natocesarrego commented Sep 29, 2022

natocesarrego commented Sep 29, 2022

bryceosterhaus commented Sep 30, 2022

natocesarrego commented Sep 30, 2022

izaera commented Oct 4, 2022 • edited Loading

bryceosterhaus commented Oct 4, 2022

bryceosterhaus commented Oct 5, 2022

bryceosterhaus commented Oct 5, 2022

bryceosterhaus commented Oct 7, 2022

bryceosterhaus commented Oct 7, 2022

liferay-continuous-integration commented Oct 7, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 23 minutes

Base Branch:

Sender Branch:

For more details click here.

bryceosterhaus commented Oct 7, 2022

bryceosterhaus commented Oct 7, 2022

bryceosterhaus commented Oct 7, 2022

liferay-continuous-integration commented Oct 7, 2022

liferay-continuous-integration commented Oct 7, 2022

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 949 out of 1090 jobs passed in 3 hours 28 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

141 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Oct 7, 2022

liferay-continuous-integration commented Oct 7, 2022

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 955 out of 1090 jobs passed in 4 hours 14 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

135 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Oct 7, 2022

john-co commented Oct 11, 2022 • edited Loading

izaera commented Oct 4, 2022 •

edited

Loading

john-co commented Oct 11, 2022 •

edited

Loading