Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-65718 The duplicated entry is the typical error, but we're not sure this is the only error that could happen. Let's log a more generic error and the stacktrace #39656

Closed
wants to merge 7 commits into from
Closed

LPS-65718 The duplicated entry is the typical error, but we're not sure this is the only error that could happen. Let's log a more generic error and the stacktrace #39656

wants to merge 7 commits into from

Conversation

adolfopa
Copy link

No description provided.

adolfopa and others added 7 commits May 11, 2016 11:46
@adolfopa
LPS-65718 Remove rows that will cause a constraint violation
eb3bb0b 
These rows will be reinserted by the verify process, so no data loss is
possible here.
@adolfopa
LPS-65718 Take into accout all cases when renaming
089f02d
@adolfopa
LPS-65718 Ignore entries with no trash handler
5921210 
This method is called from a quartz task. Depending on how much time
things take to get up, it may try to clean up trash entries before its
handler component is active.
@adolfopa
LPS-65718 Ignore unique constraint on upgrade
b478f0c 
Previously, some portlets would save service preferences at the level of
layouts. This upgrade process tries to convert them to group level
settings, but it doesn't take into account the case where more than one
instance of that portlet exists in the same group.

The only portable and efficient way to handle this is to ignore the
errors and continue.
@adolfopa
LPS-65718 Wait until upgrades have finished
a393a56
@migue @adolfopa
LPS-65718 This should not be required. It's already waiting for the C…
ead0ce6 
…alendarBookingLocalService
@migue @adolfopa
LPS-65718 The duplicated entry is the typical error, but we're not su…
6f62fc7 
…re this is the only error that could happen. Let's log a more generic error and the stacktrace
@adolfopa adolfopa mentioned this pull request May 11, 2016
Closed
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 49 minutes 40 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 842711a9a7991ec122b066f78ad5a8b85e2654a8

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    63 Jobs Passed.
    4 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/19
    Job Results:

    13 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[Calendar#DeleteEventRegular] - Calendar#AddEventRepeatingMonthly2Times - Calendar#AddResourceCalendarToOtherCalendars - Calendar#DeleteEventRegular - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/7
    Job Results:

    31 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[Forms#ConfigureDataProviderWithSelectField] - ExportImport#ImportCorruptedFile - Forms#ConfigureDataProviderWithSelectField - Forms#NavigateToCorrectForm - Poshi Summary - Console Output
  4. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql56-jdk7
    Job Results:

    4668 Tests Passed.
    14 Tests Failed.

    1. DLFileEntryTypeServiceTest.testAddFileEntryType
    2. MBThreadTrashHandlerTest.testCategoryMessageCount
    3. WikiNodeStagedModelDataHandlerTest.testCleanStagedModelDataHandler
    4. ...

    Click here for more failures.

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 441a7a2...bc5d4fd

@brianchandotcom
Copy link
Owner

@jhendley @pyoo47 @adolfopa we need this in CI too... or else it'll degenerate very quickly

@adolfopa adolfopa deleted the pr-275 branch June 30, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adolfopa @liferay-continuous-integration @brianchandotcom @migue