Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-60487 Skip CacheFilter for /webdav/* #42187

Closed
wants to merge 14 commits into from
Closed

LPS-60487 Skip CacheFilter for /webdav/* #42187

wants to merge 14 commits into from

Conversation

tinatian
Copy link

Hi Brian,

We made this change beacuse all /webdav/* requests (not just /webdav/.js and /webdav/.css) are always dynamic and should never be cached.

cc @ChrisKian @holatuwol @shuyangzhou

Thanks.
Tina.

@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/message-boards/.git…
d37238b 
…repo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/wiki/.gitrepo'.
de5e894
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/dynamic-data-l…
e068439 
…ists/.gitrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/dynamic-data-m…
4e2772b 
…apping/.gitrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/frontend-theme/.gitrepo'.
c61035b
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/portal-search/.gitrepo'.
c7b49af
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/portal-security-sso/.g…
0ed3d3f 
…itrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/portal-template/.gitre…
4010721 
…po'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/marketplace/.gitrepo'.
65332fd
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/asset/.gitrepo'.
8fd5921
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/export-import/.git…
b0c8faf 
…repo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/journal/.gitrepo'.
8969e46
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/site-navigation/.g…
0fa60d2 
…itrepo'.
@ChrisKian @tinatian
LPS-60487 Add webDav to the cache filter
2c5fc3f
@tinatian tinatian mentioned this pull request Aug 10, 2016
Closed
@tinatian tinatian changed the title LPS-60478 Skip CacheFilter for /webdav/* LPS-60487 Skip CacheFilter for /webdav/* Aug 10, 2016
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 57 minutes 57 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 0fa60d25773fd718c4abdff78865624ac1cc73e7

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    67 Jobs Passed.
    3 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-sybase16-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #26638
           [exec]  at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
     [exec]   at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
     [exec]   at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
     [exec]   at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:585)
     [exec]   at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1794)
     [exec]   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
     [exec]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec]   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     [exec]   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     [exec]   at java.lang.Thread.run(Thread.java:745)
     [exec] Stopping the server due to unexpected startup errors
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:582: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8287: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2858: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2954: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3302: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3466: Unable to find startup message after 15 minutes.
      [get] Getting: http://test-1-9/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/26638//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160809202005040.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160809202005040.txt
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-sybase16-jdk8/1
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #27610
           [exec]    at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
     [exec]   at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
     [exec]   at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
     [exec]   at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:585)
     [exec]   at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1794)
     [exec]   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
     [exec]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec]   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     [exec]   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     [exec]   at java.lang.Thread.run(Thread.java:745)
     [exec] Stopping the server due to unexpected startup errors
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:582: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8287: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2858: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2954: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3302: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3466: Unable to find startup message after 15 minutes.
      [get] Getting: http://test-1-4/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/27610//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160809202135319.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160809202135319.txt
For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 5d7a11b...9985e97

@brianchandotcom
Copy link
Owner

@tinatian @ChrisKian see a02ef52

Thx.

@tinatian tinatian deleted the LPS-LPS-60487-8-10 branch June 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinatian @liferay-continuous-integration @brianchandotcom @ChrisKian