Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lps 68046 #42998

Closed
wants to merge 7 commits into from
Closed

Lps 68046 #42998

wants to merge 7 commits into from

Conversation

shuyangzhou
Copy link

@dantewang @slnn performance check please.

CC @Preston-Crary

@shuyangzhou
LPS-68046 Always use MethodInvocation.proceed(), MethodInvocation int…
e8b95a4 
…ernally is an invocation chain. After completing the current arguments manipulation, it needs to move on to finish the entire chain. The only reason we have not seen a broken case so far, is because PortletPreferencesLocalServiceStagingAdvice just happened to be the last AOP advice before reaching to the real target. In case anyone changes the Spring xml to inject anthor AOP advice in between this adivce and the real target, the old code will actually bypass the new advice directly hitting the real target causing issues.
@shuyangzhou
LPS-68046 Add references
2e1c758
@shuyangzhou
LPS-68046 Inline getPortletPreferencesCount() aop logic.
00efe43
@shuyangzhou
LPS-68046 Inline getPreferences()/getStrictPreferences() aop logic
f05e34e
@shuyangzhou
LPS-68046 Inline updatePreferences() aop logic
15fb9bc
@shuyangzhou
LPS-68046 Inline getPortletPreferences() aop logic
06abe31
@shuyangzhou
LPS-68046 Remove PortletPreferencesLocalServiceStagingAdvice
3d8363b
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 2 minutes 30 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 38d242bdc6197c37846fa49e57cc575fc98fa03a

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-source(master)
         [exec] Warning: Permanently added 'github.liferay.com,10.0.0.13' (RSA) to the list of known hosts.
     [exec] fatal: Couldn't find remote ref cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4
     [exec] Executing "git fetch --progress -v -f git@github.liferay.com:liferay/liferay-portal.git cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4:master-temp-20160908091655491" encountered an error.
     [exec] 
     [exec] Retrying the following command in 30 seconds:
     [exec] 
     [exec] "/opt/dev/projects/github/liferay-jenkins-ee/commands/git_custom_fetch.sh -f git@github.liferay.com:liferay/liferay-portal.git cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4:master-temp-20160908091655491"
     [exec] 
     [exec] Executing "git fetch --progress -v -f git@github.liferay.com:liferay/liferay-portal.git cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4:master-temp-20160908091655491".
     [exec] Warning: Permanently added 'github.liferay.com,10.0.0.18' (RSA) to the list of known hosts.
     [exec] fatal: Couldn't find remote ref cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4
     [exec] Executing "git fetch --progress -v -f git@github.liferay.com:liferay/liferay-portal.git cache-brianchandotcom-38d242bdc6197c37846fa49e57cc575fc98fa03a-shuyangzhou-3d8363bcc60db04a648ea1898ddb056faf8195a4:master-temp-20160908091655491" encountered an error.
     [exec] GIT Custom Fetch had failed!
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160908091729161

    BUILD FAILED
    
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-source.xml:162: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-source.xml:132: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:6356: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:557: exec returned: 1
For upstream results, click here.

@shuyangzhou
Copy link
Author

@michaelhashimoto ?

@michaelhashimoto
Copy link

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

Pull Request was closed!

This pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*If you believe this is a mistake please re-open this pull. This pull will no longer automatically close if this comment is available.

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 56 minutes 29 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 7e5812b6466bb688c047f2d0691f84cddc2d4e41

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    10 Jobs Passed.
    80 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-jboss64-mysql56-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #33786
           [exec] �[0m�[31m18:44:07,186 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) JBAS013413: Timeout after [5000] seconds waiting for service container stability while finalizing an operation. Process must be restarted. Step that first updated the service container was 'add' at address '[
     [exec]     ("core-service" => "management"),
     [exec]     ("management-interface" => "native-interface")
     [exec] ]'
     [exec] �[0m�[31m18:44:07,189 FATAL [org.jboss.as.server] (Controller Boot Thread) JBAS015957: Server boot has failed in an unrecoverable manner; exiting. See previous messages for details.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:594: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-jboss.xml:30: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-jboss.xml:7: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8443: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2967: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3063: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3481: No server is available at http://localhost:8080/web/guest
      [get] Getting: http://test-1-13/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/33786//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160908115020430.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160908115020430.txt
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-hypersonic20-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #34950
           [exec]  at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:402)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundle(DirectoryWatcher.java:1252)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundles(DirectoryWatcher.java:1224)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:512)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:313)
     [exec] 18:32:57,687 INFO  [localhost-startStop-1][BundleStartStopLogger:35] STARTED com.liferay.dynamic.data.lists.web_1.1.11 [312]
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:594: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8443: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2967: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3066: 
     [echo] exec returned: 1
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3411: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3602: Unable to find startup message after 15 minutes.
      [get] Getting: http://test-1-20/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/34950//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160908114717586.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160908114717586.txt
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mariadb100-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #37063
           [exec]  at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
     [exec]   at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1562)
     [exec]   at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
     [exec]   at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
     [exec]   at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
     [exec]   at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
     [exec]   at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:594: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8443: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2967: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3066: 
     [echo] exec returned: 1
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3411: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3602: Unable to find startup message after 15 minutes.
      [get] Getting: http://test-1-4/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/37063//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160908114751912.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160908114751912.txt
  5. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mariadb100-jdk8/1
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #18862
           [exec] 
     [exec]   at org.eclipse.osgi.container.Module.start(Module.java:429)
     [exec]   at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:402)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundle(DirectoryWatcher.java:1252)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundles(DirectoryWatcher.java:1224)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:512)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
     [exec]   at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:313)
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:594: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8443: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2967: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3066: 
     [echo] exec returned: 1
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3411: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3602: Unable to find startup message after 15 minutes.
      [get] Getting: http://test-1-8/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/18862//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160908115054755.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160908115054755.txt
  6. ...
For upstream results, click here.

@shuyangzhou
Copy link
Author

Irrelevant failures, please reopen this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuyangzhou @liferay-continuous-integration @michaelhashimoto