Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master-vw-626 #44768

Closed
wants to merge 5 commits into from
Closed

master-vw-626 #44768

wants to merge 5 commits into from

Conversation

vicnate5
Copy link
Collaborator

Thanks @diogo-lins

This was referenced Nov 15, 2016
Closed
Closed
@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED.

Build Time: 1 hour 45 minutes 0 second

Base Branch:

Branch Name: master
Branch GIT ID: 4a9e114ad35116d9ca2042e9c64d5c257017d81c

Job Summary:

For more details click here.
For upstream results, click here.

@brianchandotcom
Copy link
Owner

@jbalsas fyi. Please see test infrastructure.

@jbalsas
Copy link

jbalsas commented Nov 17, 2016

This won't be running in the CI if that was the goal... we should follow the the pattern designed in https://github.com/liferay/liferay-portal/tree/master/modules/apps/foundation/frontend-js/frontend-js-web.

@vicnate5, @diogo-lins, could you please take a look to adapt and enable in the CI? email me if you guys need any kind of explanation.

Thanks!

@brunobasto
Copy link

Hey @jbalsas,

When you say follow the pattern you mean the folder structures and adding the

testJS {
	dependsOn gulpTest
}

on the gradle file, right? Cause the other stuff (metal-karma, gulp-metal) doesn't really apply to this code.

Thx,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vicnate5 @liferay-continuous-integration @brianchandotcom @jbalsas @brunobasto