Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69689 Search Result List: extract code from JSP into reusable Display Contexts #45497

Closed
wants to merge 9 commits into from
Closed

LPS-69689 Search Result List: extract code from JSP into reusable Display Contexts #45497

wants to merge 9 commits into from

Conversation

arboliveira
Copy link

@arboliveira arboliveira commented Dec 14, 2016 •
edited
Loading

@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/document-library/.g…
f0bcd32 
…itrepo'.
@arboliveira
LPS-66715 Even less Util
457b7a3
@arboliveira
LPS-69689 Never thrown
64e8532 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 Delete constructor- unused, in an internal package
e840332 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 PortletURLFactory: no more arguments
2357e01 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 [TEST] PortletURLFactory: no more arguments
c164e4d 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 Extract: ThemeDisplay Supplier
1e343d4 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 Extract: Search Result Preferences
8d1320c 
https://issues.liferay.com/browse/LPS-69689
@arboliveira
LPS-69689 Extract: Search Result Summary- Display Context and Builder
77b012b 
https://issues.liferay.com/browse/LPS-69689
@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED.

Build Time: 1 hour 17 minutes 9 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 5bab43b09dae0fd3067d63be5dc0ccc23797bc81

Job Summary:

For more details click here.
For upstream results, click here.

@brianchandotcom
Copy link
Owner

@arboliveira can you full var this

SearchResultFieldDisplayContext srfdc =

SearchResultSummary is unusual. Can you have it match our usual patterns (I know.. verbose).

Please resend. Thx.

@arboliveira arboliveira mentioned this pull request Dec 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arboliveira @liferay-continuous-integration @brianchandotcom