Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69113 Fix tracker filter #46441

Closed
wants to merge 1 commit into from
Closed

LPS-69113 Fix tracker filter #46441

wants to merge 1 commit into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented Jan 27, 2017

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 38 minutes 26 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 4ef00c57badda5f26b56adb37dc6e93830d48ab3

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    95 Jobs Passed.
    3 Jobs Failed.

    [beanshell] TEST_BATCH_NAME=functional-upgrade-tomcat80-mariadb100-jdk8
[beanshell] JENKINS_LOCAL_GIT_BRANCH_CACHED=true
[beanshell] TOP_LEVEL_GITHUB_COMMENT_ID=275726945
[beanshell] GITHUB_PULL_REQUEST_NUMBER=46441
[beanshell] JENKINS_GITHUB_SENDER_BRANCH_SHA=922af08fd4bf0f199bdb71efc70838477e4721b8
[beanshell] GITHUB_ORIGIN_NAME=jbalsas
[beanshell] GITHUB_RECEIVER_USERNAME=brianchandotcom
[beanshell] TEST_BATCH_RUN_TYPE=sequential
[beanshell] TOP_LEVEL_JOB_NAME=test-portal-acceptance-pullrequest(master)
[beanshell] GITHUB_UPSTREAM_BRANCH_SHA=4ef00c57badda5f26b56adb37dc6e93830d48ab3
[beanshell] EMAIL_LIST=qa-slave-verify-fail@liferay.com
[beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_SHA=922af08fd4bf0f199bdb71efc70838477e4721b8
[beanshell] RUN_TEST_CASE_METHOD_GROUP_0_0=PortalSmokeUpgrade#ViewPortalSmokeArchive623
[beanshell] JENKINS_PULL_REQUEST_DIST_NODES=cloud-10-0-112-88,cloud-10-0-12-109,cloud-10-0-12-149,cloud-10-0-17-34,cloud-10-0-113-24,cloud-10-0-19-102,cloud-10-0-14-157,cloud-10-0-110-174,cloud-10-0-19-148,cloud-10-0-16-215,cloud-10-0-12-151,cloud-10-0-110-181,cloud-10-0-16-154,cloud-10-0-113-138,cloud-10-0-110-219,cloud-10-0-113-27,cloud-10-0-17-173,cloud-10-0-110-236,cloud-10-0-19-128,cloud-10-0-19-125,cloud-10-0-111-156
[beanshell] TOP_LEVEL_MASTER_HOSTNAME=test-1-6
[beanshell] BUILD_DESCRIPTION=brianchandotcom - PR#46441 - Jenkins Report
[beanshell] TOP_LEVEL_BRANCH_NAME=master-temp-20170127094521688
[beanshell] TOP_LEVEL_BUILD_URL=https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest(master)/882/
[beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_NAME=master
[beanshell] GITHUB_SENDER_USERNAME=jbalsas
[beanshell] JENKINS_GITHUB_RECEIVER_USERNAME=liferay
[beanshell] TEST_BATCH_SIZE=1
[beanshell] DIST_ROOT_PATH=/test-1-6
[beanshell] TOP_LEVEL_BUILD_NUMBER=882
[beanshell] TOP_LEVEL_START_TIME=1485539122316
[beanshell] JENKINS_GITHUB_PULL_REQUEST_NUMBER=0
[beanshell] SUBREPOSITORY_CI_MERGE_FILES=
[beanshell] TOP_LEVEL_BUILD_DESCRIPTION=brianchandotcom - PR#46441 - Jenkins Report
  2. test-portal-acceptance-pullrequest-batch(master)/integration-sybase160-jdk8
    Job Results:

    5205 Tests Passed.
    1 Test Failed.

    1. AssetVocabularyServiceTest.testDeleteVocabulary
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8
    Job Results:

    5676 Tests Passed.
    2 Tests Failed.

    1. UserIndexerTest.testNamesPrefix
    2. UserIndexerTest.testNamesSubstring
For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thx.

@brianchandotcom
Copy link
Owner

@jbalsas backported!

@jbalsas
Copy link
Author

jbalsas commented Jan 27, 2017

great, thanks a lot! ☺️

@jbalsas
Copy link
Author

jbalsas commented Jan 27, 2017 •
edited
Loading

hey @brianchandotcom, @hhuijser, this simple issue caused all RTL to fail. Could we enforce this through SourceFormatter so inside filterString or similar there are no spaces around the = signs?

/cc @csierra

@hhuijser
Copy link

@jbalsas, I added it to my todo list. Right now, lots of stuff on my plate, so it might take a while...

@hhuijser
Copy link

hhuijser commented Feb 3, 2017

@jbalsas do you mind opening a new LPS ticket for this that describes the issue and why exactly we should not use spaces in those filters?

@jbalsas
Copy link
Author

jbalsas commented Feb 8, 2017

Hey @hhuijser, I've opened https://issues.liferay.com/browse/LPS-70526 with the description and some explanation. It seems the filter is space sensitive, and that's that :)

@jbalsas jbalsas deleted the LPS-69113-RTL branch April 3, 2017 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbalsas @liferay-continuous-integration @brianchandotcom @hhuijser