LPS-71381 As a developer, I would like to be able to get System-scoped configurations using the ConfigurationProviderUtil #47751
Conversation
…method to get system-scoped configuration
…updates build dependencies
…oviderImpl - implements new interface method
…d dependencies (fix deployment error)
|
Pull request test invoked at http://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
Hey @brianchandotcom, this pull adds a method that will speed up development on a few of our other stories. If you could take a look at this soon, it would help us a lot. Thanks! |
|
ci:retest |
|
Pull request test invoked at http://test-1-19.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
Merged. Thank you. |
|
@drewbrokke is this safe to backport? If so, please do so. Thx. |
|
@JorgeFerrer this looks safe to me, and I can imagine other modules needing something like this. @drewbrokke if it's not, just leave it as master only. Thx |
|
My main doubt is, what are the consequences to increasing the minor number in the portal-kernel version? |
|
@JorgeFerrer I don't think this would increase |
|
Hmm, but you are adding a method to an existing interface (ProviderType) of the API. Shouldn't that force you to change the minor version of the module? |
|
My understanding is no, since the increased minor versions of the packages do not surpass the minor version of the module itself. I may be mis-remembering how the package to module versioning relationship works, but in any case the versioning is automated when building |
|
Hey @brianchandotcom, Zoltan is asking why this one should be backported. He's not sure it meets the requirements. https://github.com/dustinryerson/liferay-portal-ee/pull/2785#issuecomment-294748268. Why do you want to backport this story? I'm just not sure what to tell him right now, since I don't think it's totally necessary (but would be nice to have). |
|
Hey Drew,
I don't think this is a must, but it adds value since the API was
incomplete without this method (so it could be considered a perceived bug).
Also it seems to have a very low risk, doesn't it?
Why does Zoltan believe that it does not meet the criteria?
|
|
I believe it was mostly because the ticket was not classified as a bug. I think they're (rightfully) wary of backporting stories if they don't have to. Thanks for your comment on the pull. |
This is an update for LPS-71381.
/cc @pei-jung @JorgeFerrer