[See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy #48070

jbalsas · 2017-04-04T09:09:01Z

Hey Brian,

I'm resending #48044 after going over your comments. Some clarifications:

When deploying the flags module, nothing breaks in runtime. All applications using the taglib keep working normally.
We have transitive dependencies disabled in the build. This forces everyone using the taglib to also declare its transitive dependencies (in order to be able to compile) now, but it is an expected build update
For CI, we have compileJSP enabled, that's what surfaces the build error in our case.

As far as we see, there's nothing else we can do, nor should we.

/cc @ambrinchaudhary, @sergiogonzalez, @migue

…ht be false.

…sage saying "flags-are-disabled-because-this-entry-is-in-the-recycle-bin"

@jbalsas

…greed with @jbalsas that we will use the new package soy for the new soy taglibs

…ect these dependencies

liferay-continuous-integration · 2017-04-04T09:09:04Z

Pull request test invoked at http://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master).

liferay-continuous-integration · 2017-04-04T10:11:45Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@jbalsas

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

source-format-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #84948

format-source:
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-kernel/test-classes/unit/system-ext.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/util-java/test-classes/unit/system-ext.properties
     [java] /opt/dev/projects/github/liferay-portal/modules/apps/collaboration/message-boards/message-boards-web/build.gradle
     [java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/apps/collaboration/message-boards/message-boards-web/build.gradle expected:&lt;...tcha:captcha-api")
     [java] }[]> but was:&lt;...tcha:captcha-api")
     [java] }[
     [java] ]>
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:1240)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor.format(BaseSourceProcessor.java:562)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:124)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:119)
     [java] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     [java] 	at java.lang.Thread.run(Thread.java:745)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
      [get] Getting: http://test-1-5/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/84948//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20170404031133906.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170404031133906.txt

jbalsas · 2017-04-04T10:33:21Z

ci:reopen

liferay-continuous-integration · 2017-04-04T12:04:24Z

Some tests FAILED.

Build Time: 2 hours 55 minutes 7 seconds 281 ms

Base Branch:

Branch Name: master
Branch GIT ID: d91f06eab99c1ce93b71f80229749667a4243b87

Job Summary:

For more details click here.

Failed Jobs:

test-portal-acceptance-pullrequest(master)
Job Results:
91 Jobs Passed.
5 Jobs Failed.
```
Downstream jobs FAILED.
```
test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8
Job Results:
4784 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=3,label_exp=!master #80918
  1. SocketTest.testConnect1
test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
Job Results:
2 Tests Passed.
0 Tests Failed.

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #80919

     [exec] 	at com.liferay.portal.tools.service.builder.ServiceBuilder.getEntity(ServiceBuilder.java:1113)
     [exec] 	at com.liferay.portal.tools.service.builder.ServiceBuilder.getEntity(ServiceBuilder.java:1198)
     [exec] 	at com.liferay.portal.tools.service.builder.ServiceBuilder._resolveEntity(ServiceBuilder.java:5727)
     [exec] 	at com.liferay.portal.tools.service.builder.ServiceBuilder.&lt;init>(ServiceBuilder.java:738)
     [exec] 	at com.liferay.portal.tools.service.builder.ServiceBuilder.main(ServiceBuilder.java:219)
     [exec] :apps:shopping:shopping-service:buildService FAILED
     [exec] 
     [exec] BUILD FAILED
     [exec] 
     [exec] Total time: 6 mins 5.284 secs
     [exec] Gradle build finished at 2017-04-04 10:20:59.161.
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:shopping:shopping-service:buildService'.
     [exec] > Process 'command '/opt/java/jdk1.8.0_51/bin/java'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:shopping:shopping-service:buildService'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #84948

format-source:
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-kernel/test-classes/unit/system-ext.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/util-java/test-classes/unit/system-ext.properties
     [java] /opt/dev/projects/github/liferay-portal/modules/apps/collaboration/message-boards/message-boards-web/build.gradle
     [java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/apps/collaboration/message-boards/message-boards-web/build.gradle expected:&lt;...tcha:captcha-api")
     [java] }[]> but was:&lt;...tcha:captcha-api")
     [java] }[
     [java] ]>
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:1240)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor.format(BaseSourceProcessor.java:562)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:124)
     [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:119)
     [java] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     [java] 	at java.lang.Thread.run(Thread.java:745)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
      [get] Getting: http://test-1-5/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/84948//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20170404031133906.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170404031133906.txt

For upstream results, click here.

jpince · 2017-04-04T14:52:07Z

@brianchandotcom SF is complaining about a newline at the end of message-boards-web/build.gradle, but no change was made, and this file looks the same as any other build.gradle.

brianchandotcom · 2017-04-04T22:27:18Z

Merged. Thank you.
View total diff: 6d39c21...b6a18dc

brianchandotcom · 2017-04-04T22:29:54Z

@jbalsas thank you for explaining this in detail. You understood my objections and your statements make perfect sense.

@jpince the CI issue is an issue with how we are using JGit in CI.

@pyoo47 has a fix for that CI issue which I've merged in #48093

brianchandotcom · 2017-04-04T22:30:05Z

@ambrinchaudhary one minor SF change in c054e42

jbalsas · 2017-04-05T07:31:57Z

No problem! thanks a lot @brianchandotcom!

ambrinchaudhary and others added 30 commits April 3, 2017 10:44

LPS-69436 Create metal component for Flags

b83849e

LPS-69436 Not clicable if the entry is in Trash

462ec1a

LPS-69436 Remove old markup

0f7ed16

LPS-69436 Use a div to wrap the template so we avoid rendering it twice

120287d

LPS-69436 Use Soy template rendered taglib

31314fa

LPS-69436 SF

2ec45d9

LPS-69436 Add shrinkwrap

08942e9

LPS-69436 Add JSDoc

b4f8ee3

LPS-69436 Add missing dependency

eec944e

LPS-69436 Update metal dependencies

aea4258

LPS-69436 Add template description

05203d9

LPS-69436 Extend from TemplateRendererTag

736344e

LPS-69436 Remove js folder

cfe8638

LPS-69436 Use released artifact

c223cbb

LPS-69436 Update shrinkwrap

7ad2c7f

LPS-69436 Add missing dependency

22e8aa8

LPS-69436 SF

054b7e4

LPS-69436 Baseline

2a5a21c

LPS-69436 SF

4407195

LPS-69436 SF

32e6666

LPS-69436 SF

f76ce7f

LPS-69436 Always send label even though it might not be set or it mig…

5906089

…ht be false.

LPS-69436 Same for message

ccfeaa6

LPS-69436 Set a title. When the entry is in trash, user will se a mes…

c35fa57

…sage saying "flags-are-disabled-because-this-entry-is-in-the-recycle-bin"

LPS-69436 Avoid major change by deprecating the old taglib. We have a…

c213291

…greed with @jbalsas that we will use the new package soy for the new soy taglibs

LPS-69436 Semver

e07ab78

LPS-69436 This is not a Portlet

a741a2b

LPS-69436 Add missing dependency

8de3396

LPS-69436 SF

1b1ab1a

LPS-69436 SF

f77c0be

jbalsas and others added 5 commits April 3, 2017 11:00

LPS-69436 Removes unneded wiring since JSPCompiler is now able to det…

c4a6236

…ect these dependencies

LPS-69436 SF

372a249

LPS-69436 Rename method

3acfb37

LPS-69436 Baseline

58fc1e9

LPS-69436 Prevent micro version changes

c961cfa

jbalsas mentioned this pull request Apr 4, 2017

LPS-69436 Flag's taglib jbalsas/liferay-portal#707

Closed

jbalsas changed the title ~~LPS-69436 Prevent micro version changes~~ LPS-69436 Update Flags-Taglib with Metal.js and Soy Apr 4, 2017

jbalsas changed the title ~~LPS-69436 Update Flags-Taglib with Metal.js and Soy~~ [See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy Apr 4, 2017

liferay-continuous-integration closed this Apr 4, 2017

liferay-continuous-integration reopened this Apr 4, 2017

brianchandotcom closed this Apr 4, 2017

jbalsas deleted the pr-707 branch August 3, 2018 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy #48070

[See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy #48070

jbalsas commented Apr 4, 2017 •

edited

Loading

liferay-continuous-integration commented Apr 4, 2017

liferay-continuous-integration commented Apr 4, 2017

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

jbalsas commented Apr 4, 2017

liferay-continuous-integration commented Apr 4, 2017

test-portal-acceptance-pullrequest(master)

Job Results:

test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

jpince commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

jbalsas commented Apr 5, 2017

[See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy #48070

[See comments inside] LPS-69436 Update Flags-Taglib with Metal.js and Soy #48070

Conversation

jbalsas commented Apr 4, 2017 • edited Loading

liferay-continuous-integration commented Apr 4, 2017

liferay-continuous-integration commented Apr 4, 2017

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

jbalsas commented Apr 4, 2017

liferay-continuous-integration commented Apr 4, 2017

Some tests FAILED.

Base Branch:

Job Summary:

For more details click here.

Failed Jobs:

test-portal-acceptance-pullrequest(master)

Job Results:

test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8

Job Results:

For upstream results, click here.

jpince commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

brianchandotcom commented Apr 4, 2017

jbalsas commented Apr 5, 2017

jbalsas commented Apr 4, 2017 •

edited

Loading