LPS-69208 Move the Documents and Media file uploads settings UI from Server Administration to System Settings #51994

drewbrokke · 2017-10-05T00:06:14Z

This is an update for LPS-69208.

/cc @pei-jung, @alee8888, @xbrianlee, @JorgeFerrer

…java

…laration.java

…s props from updateFileUploads method

…fields

…t_portlet_validation.jsp - replaces props usage with configuration

… replaces props usage with configuration

…t_page_attachment.jsp - replaces props usage with configuration

…e with configuration

… and new_message.jsp - replaces props usage with configuration

…iew.jsp - replaces props usage with configuration

…figuration

… replaces props usage with configuration

… usage with configuration

…eplaces props usage with configuration

…ds upgrade processes

…crements schema dependency

…ops usage with configuration

…encies

…ency on new upgrade util

…ew upgrade util and constants

…per.java - optimize the service listener a little to be a more stable during CI runs

liferay-continuous-integration · 2017-10-05T00:06:17Z

Pull request test invoked at http://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest(master).

liferay-continuous-integration · 2017-10-05T00:50:13Z

Some tests FAILED.

Build Time: 43 minutes 45 seconds 940 ms

Base Branch:

Branch Name: master
Branch GIT ID: a47a9641bf3f01d7004e6cc3374316f62c3b554e

1 out of 2 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

1 Successful Jobs:

test-portal-acceptance-pullrequest-dist(master)/jdk8

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

1 Job Passed.
1 Job Failed.

POSHI Test Failure: Execution failed for task ':writePoshiProperties'.

     [exec] Exception in thread "main" java.lang.Exception
     [exec] 	at com.liferay.poshi.runner.PoshiRunnerValidation._throwExceptions(PoshiRunnerValidation.java:1696)
     [exec] 	at com.liferay.poshi.runner.PoshiRunnerValidation.validate(PoshiRunnerValidation.java:100)
     [exec] 	at com.liferay.poshi.runner.PoshiRunnerContext.main(PoshiRunnerContext.java:257)
     [exec] 1 errors in POSHI
     [exec] 
     [exec] 
     [exec] Invalid path locator AssetCategorization#TAG_AUTOCOMPLETE_SPECIFIC
     [exec] /opt/dev/projects/github/liferay-portal/portal-web/test/functional/com/liferay/portalweb/macros/AssetCategorization.macro:8
     [exec] 
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':writePoshiProperties'.
     [exec] > Process 'command '/opt/java/jdk1.8.0_51/bin/java'' finished with non-zero exit value 1
     [exec]

For upstream results, click here.

kenjiheigel · 2017-10-05T01:14:04Z

ci:retest

liferay-continuous-integration · 2017-10-05T01:14:07Z

Pull request test invoked at http://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest(master).

liferay-continuous-integration · 2017-10-05T02:57:17Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@drewbrokke

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

modules-unit-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

2717 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=3,label_exp=!master #105491

PoshiElementFactoryTest.testPoshiToReadableToXML

java.lang.Exception: Readable syntax does not translate to XML
	at com.liferay.poshi.runner.elements.PoshiElementFactoryTest.testPoshiToReadableToXML(PoshiElementFactoryTest.java:61)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.gradle.api.internal.tasks.te...

liferay-continuous-integration · 2017-10-05T04:15:32Z

Some tests FAILED.

Build Time: 3 hours 1 minute 12 seconds 69 ms

Base Branch:

Branch Name: master
Branch GIT ID: 9c1f23d3081ec566c2f7e5c8321046e282a77605

115 out of 119 jobs PASSED

4 Failed Jobs:

115 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
115 Jobs Passed.
4 Jobs Failed.
```
Downstream jobs FAILED.
```
test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8
Job Results:
7867 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=9,label_exp=!master #28049
  1. PortalLogAssertorTest.testScanOSGiLog

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

2717 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=3,label_exp=!master #105491

PoshiElementFactoryTest.testPoshiToReadableToXML

java.lang.Exception: Readable syntax does not translate to XML
	at com.liferay.poshi.runner.elements.PoshiElementFactoryTest.testPoshiToReadableToXML(PoshiElementFactoryTest.java:61)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.gradle.api.internal.tasks.te...

test-portal-acceptance-pullrequest-batch(master)/portal-license-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #171472

     [echo] modules/apps/social-private-messaging/social-private-messaging-web/build.gradle
     [echo] modules/apps/social-private-messaging/social-private-messaging-web/src/main/java/com/liferay/social/privatemessaging/web/internal/portlet/PrivateMessagingPortlet.java
     [echo] modules/apps/web-experience/export-import/export-import-web/build.gradle
     [echo] modules/apps/web-experience/export-import/export-import-web/src/main/resources/META-INF/resources/import/new_import/import_layouts_validation.jsp
     [echo] modules/apps/web-experience/export-import/export-import-web/src/main/resources/META-INF/resources/import_portlet_validation.jsp
     [echo] modules/apps/web-experience/export-import/export-import-web/src/main/resources/META-INF/resources/init.jsp
     [echo] portal-impl/src/com/liferay/portal/util/PropsValues.java
     [echo] portal-impl/src/com/liferay/portal/verify/VerifyProperties.java
     [echo] portal-impl/src/portal-legacy-7.0.properties
     [echo] portal-impl/src/portal.properties
     [echo] portal-kernel/src/com/liferay/portal/kernel/util/PropsKeys.java
     [echo] readme/7.1/BREAKING_CHANGES.markdown
     [exec] Buildfile: /opt/dev/projects/github/liferay-release-tool-ee/build-release-license.xml
     [exec] 
     [exec] check-git-diff-output:
     [exec] 
     [exec] dist:
     [exec] 
     [exec] BUILD FAILED
     [exec] /opt/dev/projects/github/liferay-release-tool-ee/build-release-license.xml:7: The following error occurred while executing this line:
     [exec] /opt/dev/projects/github/liferay-release-tool-ee/build.xml:49: exec returned: 255
     [exec] 
     [exec] Total time: 1 minute 4 seconds
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:416: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:535: exec returned: 1
      [get] Getting: http://test-1-20/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/171472//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20171005022642451.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20171005022642451.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.

For upstream results, click here.

drewbrokke · 2017-10-05T16:09:46Z

ci:reopen

brianchandotcom · 2017-10-05T22:19:26Z

Merged. Thank you.
View total diff: 0bc5170...e2e786b

drewbrokke · 2017-10-05T22:51:30Z

Thanks @brianchandotcom :) One of these properties is also in liferay-journal. Do we need to publish a new version of document-library-api in order to use the new configuration value there?

drewbrokke · 2017-10-06T19:07:36Z

@brianchandotcom nevermind - I can do it without needing the new version

drewbrokke and others added 30 commits October 4, 2017 16:59

LPS-69208 document-library-api - adds properties to DLConfiguration.java

df4e14d

LPS-69208 document-library-api - adds DLConfigurationBeanDeclaration.…

ba85770

…java

LPS-69208 document-library-api - adds DLFileEntryConfiguration.java

4ff5f6e

LPS-69208 document-library-api - adds DLFileEntryConfigurationBeanDec…

9b1a8f8

…laration.java

LPS-69208 document-library-api - lang - adds description keys

c175085

LPS-69208 server-admin-web - EditServerMVCActionCommand.java - remove…

a14d2e2

…s props from updateFileUploads method

LPS-69208 server-admin-web - file_uploads.jsp - removes unused input …

54983f4

…fields

LPS-69208 server-admin-web - lang - removes description lang key

56d520f

LPS-69208 export-import-web - import_layouts_validation.jsp and impor…

a6f323e

…t_portlet_validation.jsp - replaces props usage with configuration

LPS-69208 knowledge-base-web - attachments.jsp and edit_article.jsp -…

80b9469

… replaces props usage with configuration

LPS-69208 wiki-web - EditPageAttachmentsMVCActionCommand.java and edi…

32f65f6

…t_page_attachment.jsp - replaces props usage with configuration

LPS-69208 message-boards-web - edit_message.jsp - replaces props usag…

57a437a

…e with configuration

LPS-69208 social-private-messaging-web - PrivateMessagingPortlet.java…

c5e3e8c

… and new_message.jsp - replaces props usage with configuration

LPS-69208 image-uploader-web - UploadImageMVCActionCommand.java and v…

b70c996

…iew.jsp - replaces props usage with configuration

LPS-69208 document-library-web - jsps - replaces props usage with con…

a0caa9b

…figuration

LPS-69208 document-library-web - EditFileEntryMVCActionCommand.java -…

450e897

… replaces props usage with configuration

LPS-69208 document-library-service - DLValidatorImpl - replaces props…

3f46f6f

… usage with configuration

LPS-69208 document-library-service - DLProcessorRegistryImpl.java - r…

ace24eb

…eplaces props usage with configuration

LPS-69208 document-library-service - UpgradeDLConfiguration.java - ad…

2ed28d3

…ds upgrade processes

LPS-69208 document-library-service - DLServiceVerifyProcess.java - in…

011e1a8

…crements schema dependency

LPS-69208 document-library-test - DLAppServiceTest.java - replaces pr…

b5ef8fa

…ops usage with configuration

LPS-69208 document-library-test - build.gradle - updates build depend…

a62bc5c

…encies

LPS-69208 portal-kernel - deprecates constants in PropsKeys.java

0304274

LPS-69208 portal-impl - deprecates constants in PropsValues.java

6495e76

LPS-69208 portal-impl - removes properties from portal.properties

dad1864

LPS-69208 BREAKING_CHANGES - updates 7.1 breaking changes file

6e4964d

LPS-69208 document-library-api - bumps packageinfo

947935c

LPS-69208 Follow original portal.properties

af3f551

LPS-69208 move it out of init.jsp since it's only used twice

0db1451

LPS-69208 SF

6e0391c

brianchandotcom and others added 11 commits October 4, 2017 16:59

LPS-69208 move it out of init.jsp since it's only used once

6209269

LPS-69208 lang keys

14fddd9

LPS-69208 move in

73aa6f1

LPS-69208 move in

0d76b35

LPS-69208 SF

68b7cc9

LPS-69208 SF

11096a2

LPS-69208 lang keys

e4ed581

LPS-69208 document-library-service - build.gradle - adds build depend…

4c25545

…ency on new upgrade util

LPS-69208 document-library-service - adds LegacyDLKeys.java

9528c4d

LPS-69208 document-library-service - updates Upgrade classes to use n…

3c61e92

…ew upgrade util and constants

LPS-69208 portal-configuration-test-util - ConfigurationTemporarySwap…

9d307e0

…per.java - optimize the service listener a little to be a more stable during CI runs

liferay-continuous-integration closed this Oct 5, 2017

liferay-continuous-integration reopened this Oct 5, 2017

brianchandotcom closed this Oct 5, 2017

drewbrokke deleted the LPS-69208-since-Oct-3 branch November 16, 2023 17:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-69208 Move the Documents and Media file uploads settings UI from Server Administration to System Settings #51994

LPS-69208 Move the Documents and Media file uploads settings UI from Server Administration to System Settings #51994

drewbrokke commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

1 Failed Jobs:

test-portal-acceptance-pullrequest(master)

Job Results:

kenjiheigel commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

liferay-continuous-integration commented Oct 5, 2017

4 Failed Jobs:

test-portal-acceptance-pullrequest(master)

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/portal-license-jdk8

Job Results:

drewbrokke commented Oct 5, 2017

brianchandotcom commented Oct 5, 2017

drewbrokke commented Oct 5, 2017

drewbrokke commented Oct 6, 2017

LPS-69208 Move the Documents and Media file uploads settings UI from Server Administration to System Settings #51994

LPS-69208 Move the Documents and Media file uploads settings UI from Server Administration to System Settings #51994

Conversation

drewbrokke commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

Some tests FAILED.

Base Branch:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

kenjiheigel commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

liferay-continuous-integration commented Oct 5, 2017

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

liferay-continuous-integration commented Oct 5, 2017

Some tests FAILED.

Base Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/portal-license-jdk8

Job Results:

For upstream results, click here.

drewbrokke commented Oct 5, 2017

brianchandotcom commented Oct 5, 2017

drewbrokke commented Oct 5, 2017

drewbrokke commented Oct 6, 2017