Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-78897 Announcement portlet's titles wrongly translated to Finnish and Swedish #56311

Closed
wants to merge 1 commit into from
Closed

LPS-78897 Announcement portlet's titles wrongly translated to Finnish and Swedish #56311

wants to merge 1 commit into from

Conversation

robertoDiaz
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" for this pull to run Source Formatter tests.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@robertoDiaz
Copy link
Author

/cc @dacousalr

:octocat: Sent from GH.

@robertoDiaz robertoDiaz mentioned this pull request Mar 19, 2018
Closed
@robertoDiaz
Copy link
Author

ci:test

@robertoDiaz
Copy link
Author

cc/ @laszlopap

Hi @sergiogonzalez I've pass this pr directly to Brian since the translations have been confirmed here and I guess that your finnish and swedish is as good as mine :)

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 2 out of 2 jobs passed in 13 minutes 8 seconds 272 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a64572ae6b34091ffc9c112114344f226ee76a20

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 14384628fc5d5783d9387d2f1b8b4ee4cfc08c45

2 out of 2 jobs PASSED
2 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@robertoDiaz

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
Job Results:

7 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #200822
    1. ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Incorrect configuration of dependency {provided project(":apps:collaboration:bookmarks:bookmarks-uad")} in modules/apps/collaboration/bookmarks/bookmarks-uad-test/build.gradle, use one of these instead: "testIntegrationCompile", "testIntegrationRuntime"
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1170)
	at com.liferay.portal.modules.ModulesStructureTest.access$500(ModulesStructureTest.java:64)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:272)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:247)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:245)

@robertoDiaz
Copy link
Author

ci:reopen

@robertoDiaz
Copy link
Author

Errors are not related with the pr

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 112 out of 120 jobs passed in 1 hour 43 minutes 47 seconds 966 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a64572ae6b34091ffc9c112114344f226ee76a20

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 14384628fc5d5783d9387d2f1b8b4ee4cfc08c45

112 out of 120 jobs PASSED
112 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
    Job Results:

    7 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #200822
      1. ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Incorrect configuration of dependency {provided project(":apps:collaboration:bookmarks:bookmarks-uad")} in modules/apps/collaboration/bookmarks/bookmarks-uad-test/build.gradle, use one of these instead: "testIntegrationCompile", "testIntegrationRuntime"
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1170)
	at com.liferay.portal.modules.ModulesStructureTest.access$500(ModulesStructureTest.java:64)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:272)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:247)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:245)
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mariadb100-jdk8
    Job Results:

    19 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=15,label_exp=!master #222617
           [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Configuration on demand is an incubating feature.
     [exec] Generating JAR file 'gradle-test-kit-3.3.jar'
     [exec] Generating JAR file 'gradle-api-3.3.jar'
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * Where:
     [exec] Build file '/opt/dev/projects/github/liferay-portal/modules/apps/foundation/apio-architect/build.gradle' line: 17
     [exec] 
     [exec] * What went wrong:
     [exec] A problem occurred evaluating project ':apps:foundation:apio-architect'.
     [exec] > Could not resolve all dependencies for configuration 'classpath'.
     [exec]    > Could not resolve com.liferay:com.liferay.gradle.plugins.app.docker:1.0.2.
     [exec]      Required by:
     [exec]          unspecified:unspecified:unspecified
     [exec]       > Could not resolve com.liferay:com.liferay.gradle.plugins.app.docker:1.0.2.
     [exec]          > Could not get resource 'https://cdn.lfrs.sl/repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.gradle.plugins.app.docker/1.0.2/com.liferay.gradle.plugins.app.docker-1.0.2.pom'.
     [exec]             > Could not GET 'https://cdn.lfrs.sl/repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.gradle.plugins.app.docker/1.0.2/com.liferay.gradle.plugins.app.docker-1.0.2.pom'.
     [exec]                > Remote host closed connection during handshake
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.GradleScriptException: A problem occurred evaluating project ':apps:foundation:apio-architect'.
     [exec] 	at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:92)
     [exec] 	at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl$2.run(DefaultScriptPluginFactory.java:176)
     [exec] 	at org.gradle.configuration.ProjectScriptTarget.addConfiguration(ProjectScriptTarget.java:77)
  3. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
    Job Results:

    3948 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #190614
      1. JSPSourceProcessorTest.testFormatBooleanScriptlet
        org.junit.ComparisonFailure: expected:<...y-ui:panel-container[ extended="<%= true %>" id='<%= renderResponse.getNamespace() + "facetAssetEntriesPanelContainer" %>' markupView="lexicon" persistState="<%= true %>"]>
	<liferay-ui:panel...> but was:<...y-ui:panel-container[
	extended="<%= true %>"
	id='<%= renderResponse.getNamespace() + "facetAssetEntriesPanelContainer" %>'
	markupView="lexicon"
	persistState="<%= true %>"
]>
	<liferay-ui:panel...>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at com.liferay.source.formatter.BaseSourceProcessorTestCase.test(BaseSourceProcessorTestCase.java:204)
	at com.liferay.source.formatter.BaseSourceProcessorTestCase.test(BaseSourceProcessorTestCase.java:100)
	at com.liferay.source.formatter.BaseSourceProcessorTestCase.test(BaseSourceProcessorTestCase.java:79)
	at com.liferay.source.formatter.JSPSourceProcessorTest.testFormatBooleanScriptlet(JSPSourceProcessorTest.java:26)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeEx...
  4. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #203490
           [exec]  	<bean class="com.liferay.external.data.source.test.service.persistence.impl.TestEntityPersistenceImpl" id="com.liferay.external.data.source.test.service.persistence.TestEntityPersistence" parent="basePersistence" />
     [exec]  </beans>
     [exec] \ No newline at end of file
     [exec] diff --git a/portal-impl/src/META-INF/portal-spring.xml b/portal-impl/src/META-INF/portal-spring.xml
     [exec] index c886364..c811c1f 100644
     [exec] --- a/portal-impl/src/META-INF/portal-spring.xml
     [exec] +++ b/portal-impl/src/META-INF/portal-spring.xml
     [exec] @@ -1,6 +1,6 @@
     [exec]  <?xml version="1.0"?>
     [exec]  
     [exec] -<beans default-destroy-method="destroy" default-init-method="afterPropertiesSet" xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">
     [exec] +<beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" default-destroy-method="destroy" default-init-method="afterPropertiesSet" xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">
     [exec]  	<bean class="com.liferay.portlet.announcements.service.impl.AnnouncementsDeliveryLocalServiceImpl" id="com.liferay.announcements.kernel.service.AnnouncementsDeliveryLocalService" />
     [exec]  	<bean class="com.liferay.portlet.announcements.service.impl.AnnouncementsDeliveryServiceImpl" id="com.liferay.announcements.kernel.service.AnnouncementsDeliveryService" />
     [exec]  	<bean class="com.liferay.portlet.announcements.service.persistence.impl.AnnouncementsDeliveryPersistenceImpl" id="com.liferay.announcements.kernel.service.persistence.AnnouncementsDeliveryPersistence" parent="basePersistence" />
     [echo] .
     [echo] 
     [echo] Detected build services changes. See above build services log for more
     [echo] information. Make sure to commit in all build services results.
      [get] Getting: http://test-1-5/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/203490//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20180319103551367.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20180319103551367.txt
Failures in common with acceptance upstream results at 95a361e:
  2. ...

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertoDiaz @liferay-continuous-integration @brianchandotcom @laszlopap