Lps 81018 #58651
Closed
Lps 81018 #58651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference way only works when there is exactly one HttpSessionInvalidator available at runtime, otherwise the addtional ones will flush away the previous HttpSessionListener reference, causing them not be abled to unregister.
|
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
|
ci:test |
liferay-continuous-integration
added
ci:test - pending
ci:test:sf - success
and removed
ci:test - missing
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 9 seconds 48 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-81018 1 Successful Jobs:For more details click here. |
|
Thanks @Ithildir ! |
liferay-continuous-integration
added
ci:test:relevant - failure
and removed
ci:test:relevant - pending
labels
❌ ci:test:relevant - 4 out of 7 jobs passed in 1 hour 23 minutes 21 seconds 173 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 3 Failed Jobs:4 Successful Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here. |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed: For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/lpkg-release-jdk8Job Results:0 Tests Passed.
|
|
ci:reopen |
|
ci:retest |
|
@michaelhashimoto ci relevant is still picking up the wrong test classes to run. |
Build started.Jenkins is currently running tests. Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
liferay-continuous-integration
added
ci:test - failure
and removed
ci:test - pending
labels
|
Hi @shuyangzhou, Lily |
|
The version is not the same but only because of the eclipse release
process, if you diff the jars you will find no (or irrelevant) source
changes.
…On Thu, May 17, 2018, 21:56 Lily Chi, ***@***.***> wrote:
Hi @shuyangzhou <https://github.com/shuyangzhou>,
We have verified the jar upgrade in LPS-69930, but the version is not same
as the current version, will check it.
Lily
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58651 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI9TCMSAp6ikqJVkjkfcVzizGcNsszFks5tzipIgaJpZM4UD2qB>
.
|
|
@shuyangzhou I used the cached jar now in 5bc0a7d Thanks @Ithildir and @rotty3000 |
|
Hi @shuyangzhou Here are test results on Login
Lily |
|
@shuyangzhou - We are looking into the ignore list still, sorry for the delays. Here's the ticket for this fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ithildir please help us to cache
on our servers, thanks!
@rotty3000 see my changes at d297e03, the other 2 commits are just SF, no logic change.
@dantewang @slnn I think you guys have previously verified the performance for this jar upgrade, right? Please double check whether the current version is the same you verified against, if not, please do it again.