Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-81638 Replace soy translations where needed #59218

Closed
wants to merge 2 commits into from

Conversation

jkappler
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 3 seconds 665 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d3f429948b678e9d8145396b3f5525ca481aff6e

Sender Branch:

Branch Name: LPS-81638
Branch GIT ID: 1142c8b8c82a573ed8e60e6d1a36c9d84283c9a1

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@jkappler
Copy link
Author

@jpince, this fixes the issue that @jbalsas mentioned to you

cc:// @ealonso

@brianchandotcom
Copy link
Owner

Merged. Thx.

@brianchandotcom
Copy link
Owner

@Ithildir can this be automatically detected? I generally don't want to replicate code:

replaceSoyTranslation {
	dependsOn transpileJS
}

If it can be auto detected.. if not, that's OK.

@jkappler jkappler deleted the LPS-81638 branch June 27, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants