LPS-64398 Multiple selection for all Facets, in portal-search instead of portal-kernel

[arboliveira]

Resend of #59504 (comment), fixing the one true test failure in the ci test relevant set.

cc/ @xbrianlee This is one of our high profile fixes in New Search, and prerequisite for our last pending feature. (Smart Facet Selections)

cc/ @brandizzi Please check: #59504 (comment), #59460 (review)

Authors: @BryanEngler @wcao20170619 @dylan-rebelak
Reviewer: @arboliveira

https://issues.liferay.com/browse/LPS-64398
https://issues.liferay.com/browse/LPS-76678
https://issues.liferay.com/browse/LPS-76679
https://issues.liferay.com/browse/LPS-73169

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 11 seconds 527 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 680af476e710c7cb5042f0645724334b22ce131e

Sender Branch:

Branch Name: LPS-64398-Facets-move-from-kernel-to-search
Branch GIT ID: 384ceead01eb2c85f2fe7dc33daf1f41a3630d68

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

• test-portal-acceptance-pullrequest(master)

@arboliveira

---

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

• central-requirements-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

---

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8

Job Results:

374 Tests Passed.
1 Test Failed.

1. AXIS_VARIABLE=0,label_exp=!master #213010

   1. FACES_1470PortletTester.runFACES_1470PortletTest

      com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl$1: org.openqa.selenium.TimeoutException: Timed out after 600 seconds waiting for visibility of element located by By.xpath: //span[contains(@id,'as7LeakInstances')]//ul/li/code[contains(text(),'AS7Leak')]
      	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.createAssertionErrorWithoutExtraInfo(WaitingAsserterImpl.java:43)
      	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertTrue(WaitingAsserterImpl.java:172)
      	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertElementDisplayed(WaitingAsserterImpl.java:76)
      	at com.liferay.faces.bridge.test.integration.issue.FACES_1470PortletTester.testAS7LeakIntancesCreated(FACES_1470PortletTester.java:279)
      	at com.liferay.faces.bridge.test.integration.issue.FACES_1470PortletTester.runFACES_1470PortletTest(FACES_1470PortletTester.java:188)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
      	at org.junit.intern...

[liferay-continuous-integration]

❌ ci:test:relevant - 6 out of 11 jobs passed in 1 hour 8 minutes 55 seconds 297 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 680af476e710c7cb5042f0645724334b22ce131e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b1d52a9e798b36003367ded622f3c85b647be1b1

6 out of 11 jobs PASSED

5 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

6 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/portal-frontend-js-jdk8
• test-portal-acceptance-pullrequest-dist(master)/dist-jdk8

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8

   Job Results:

   374 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #213010

      1. FACES_1470PortletTester.runFACES_1470PortletTest

         com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl$1: org.openqa.selenium.TimeoutException: Timed out after 600 seconds waiting for visibility of element located by By.xpath: //span[contains(@id,'as7LeakInstances')]//ul/li/code[contains(text(),'AS7Leak')]
         	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.createAssertionErrorWithoutExtraInfo(WaitingAsserterImpl.java:43)
         	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertTrue(WaitingAsserterImpl.java:172)
         	at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertElementDisplayed(WaitingAsserterImpl.java:76)
         	at com.liferay.faces.bridge.test.integration.issue.FACES_1470PortletTester.testAS7LeakIntancesCreated(FACES_1470PortletTester.java:279)
         	at com.liferay.faces.bridge.test.integration.issue.FACES_1470PortletTester.runFACES_1470PortletTest(FACES_1470PortletTester.java:188)
         	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
         	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
         	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
         	at java.lang.reflect.Method.invoke(Method.java:498)
         	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
         	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
         	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
         	at org.junit.intern...

2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

   Job Results:

   430 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #213013

      1. SearchResultsPortletTest.testDocumentWithoutSummaryIsRemoved

         java.lang.NullPointerException
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortlet.doBuildSummary(SearchResultsPortlet.java:297)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortlet.doBuildSummaries(SearchResultsPortlet.java:266)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortlet.buildSummaries(SearchResultsPortlet.java:222)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortlet.buildDisplayContext(SearchResultsPortlet.java:139)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortlet.render(SearchResultsPortlet.java:110)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortletTest.render(SearchResultsPortletTest.java:243)
         	at com.liferay.portal.search.web.internal.search.results.portlet.SearchResultsPortletTest.testDocumentWithoutSummaryIsRemoved(SearchResultsPortletTest.java:89)
         	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
         	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
         	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
         	at java.lang.reflect.Method.invoke(Method.java:498)
         	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
         	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
         	at org.junit.runners.model.FrameworkMetho...

3. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

   Job Results:

   0 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #213012

           [echo]  			getOrderByComparator());
           [echo]  	}
           [echo]  
           [echo] -	@Test
           [echo] -	public void testFilterFindByGroupId() throws Exception {
           [echo] -		_persistence.filterFindByGroupId(0, QueryUtil.ALL_POS,
           [echo] -			QueryUtil.ALL_POS, getOrderByComparator());
           [echo] -	}
           [echo] -
           [echo]  	protected OrderByComparator<FragmentCollection> getOrderByComparator() {
           [echo]  		return OrderByComparatorFactoryUtil.create("FragmentCollection",
           [echo]  			"fragmentCollectionId", true, "groupId", true, "companyId", true,
           [echo] diff --git a/modules/apps/fragment/fragment-test/src/testIntegration/java/com/liferay/fragment/service/persistence/test/FragmentEntryPersistenceTest.java b/modules/apps/fragment/fragment-test/src/testIntegration/java/com/liferay/fragment/service/persistence/test/FragmentEntryPersistenceTest.java
           [echo] index c2eda2c..1b651f8 100644
           [echo] --- a/modules/apps/fragment/fragment-test/src/testIntegration/java/com/liferay/fragment/service/persistence/test/FragmentEntryPersistenceTest.java
           [echo] +++ b/modules/apps/fragment/fragment-test/src/testIntegration/java/com/liferay/fragment/service/persistence/test/FragmentEntryPersistenceTest.java
           [echo] @@ -284,12 +284,6 @@ public class FragmentEntryPersistenceTest {
           [echo]  			getOrderByComparator());
           [echo]  	}
           [echo]  
           [echo] -	@Test
           [echo] -	public void testFilterFindByGroupId() throws Exception {
           [echo] -		_persistence.filterFindByGroupId(0, QueryUtil.ALL_POS,
           [echo] -			QueryUtil.ALL_POS, getOrderByComparator());
           [echo] -	}
           [echo] -
           [echo]  	protected OrderByComparator<FragmentEntry> getOrderByComparator() {
           [echo]  		return OrderByComparatorFactoryUtil.create("FragmentEntry",
           [echo]  			"fragmentEntryId", true, "groupId", true, "companyId", true,
           [echo] .
           [echo] 
           [echo] Detected build services changes. See above build services log for more
           [echo] information. Make sure to commit in all build services results.
            [get] Getting: http://test-1-7/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/213012//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20180602085555148.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20180602085555148.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1280686909.properties

4. test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

   Job Results:

   2549 Tests Passed.
   6 Tests Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #217582

      1. LicenseUtilAixTest.testOS

         java.lang.ExceptionInInitializerError
         	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
         	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:40)
         	at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:59)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.createProxy(ClassImposterizer.java:128)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.imposterise(ClassImposterizer.java:63)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.createMethodInvocationControl(MockCreator.java:109)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.mock(MockCreator.java:57)
         	at org.powermock.api.mockito.PowerMockito.mockStatic(PowerMockito.java:70)
         	at com.liferay.portal.util.BaseLicenseUtilTestCase.setUp(BaseLicenseUtilTestCase.java:45)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThe...

      2. LicenseUtilLinuxTest.testOS

         java.lang.ExceptionInInitializerError
         	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
         	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:40)
         	at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:59)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.createProxy(ClassImposterizer.java:128)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.imposterise(ClassImposterizer.java:63)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.createMethodInvocationControl(MockCreator.java:109)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.mock(MockCreator.java:57)
         	at org.powermock.api.mockito.PowerMockito.mockStatic(PowerMockito.java:70)
         	at com.liferay.portal.util.BaseLicenseUtilTestCase.setUp(BaseLicenseUtilTestCase.java:45)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThe...

      3. LicenseUtilWindowsTest.testOS

         java.lang.ExceptionInInitializerError
         	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
         	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:40)
         	at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:59)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.createProxy(ClassImposterizer.java:128)
         	at org.mockito.internal.creation.jmock.ClassImposterizer.imposterise(ClassImposterizer.java:63)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.createMethodInvocationControl(MockCreator.java:109)
         	at org.powermock.api.mockito.internal.mockcreation.MockCreator.mock(MockCreator.java:57)
         	at org.powermock.api.mockito.PowerMockito.mockStatic(PowerMockito.java:70)
         	at com.liferay.portal.util.BaseLicenseUtilTestCase.setUp(BaseLicenseUtilTestCase.java:45)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
         	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThe...

      4. ...

For upstream results, click here.

[arboliveira]

ci:reopen

@brianchandotcom The NullPointerException at SearchResultsPortletTest is not related to this pull. It was introduced yesterday, by #59460 (review). @brandizzi will handle it. (#59504 (comment))

[brianchandotcom]

Merged. Thank you.
View total diff: 29c6f8d...3c65738

[brianchandotcom]

@arboliveira I only modified LPS-64398 since the other LPS tickets didn't have Git commits in this pull. I'll let you handle the other LPS tickets.

@brandizzi need a fix bro!

[brandizzi]

Fix under CI test here.