Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-82339 Don't support nested portlets as part of a fragment #60206

Closed
wants to merge 1 commit into from
Closed

LPS-82339 Don't support nested portlets as part of a fragment #60206

wants to merge 1 commit into from

Conversation

ealonso
Copy link

@ealonso ealonso commented Jun 13, 2018

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 52 seconds 525 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 10d8cecdd5a6df3310b3dbb3d6d4cbe96162ec20

Sender Branch:

Branch Name: LPS-82339
Branch GIT ID: 590794753c8d5ef19936c1ad165bb9148e613352

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 3 out of 9 jobs passed in 1 hour 11 minutes 1 second 108 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: dac8b5668aa95bc1066bb9da661b55d51420d33d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: cc8d5e19f2827da1c70127b21010b7096be65d47

3 out of 9 jobs PASSED
3 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 66c986d:
  1. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
    Job Results:

    2 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #220242
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:408)
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:426)
	at com.liferay.portal.kernel.xml.UnsecureSAXReaderUtil.read(UnsecureSAXReaderUtil.java:74)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.readLiferayPortletXML(PortletLocalServiceImpl.java:2090)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.initEAR(PortletLocalServiceImpl.java:767)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:158)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:135)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:145)
	at com.sun.proxy.$Proxy171.initEAR(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.initEAR(PortletLocalServiceUtil.java:3...
  2. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
    Job Results:

    5 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #222359
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:408)
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:426)
	at com.liferay.portal.kernel.xml.UnsecureSAXReaderUtil.read(UnsecureSAXReaderUtil.java:74)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.readLiferayPortletXML(PortletLocalServiceImpl.java:2090)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.initEAR(PortletLocalServiceImpl.java:767)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:158)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:135)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:145)
	at com.sun.proxy.$Proxy159.initEAR(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.initEAR(PortletLocalServiceUtil.java:3...
  3. test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #89173
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:408)
	at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:426)
	at com.liferay.portal.kernel.xml.UnsecureSAXReaderUtil.read(UnsecureSAXReaderUtil.java:74)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.readLiferayPortletXML(PortletLocalServiceImpl.java:2090)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.initEAR(PortletLocalServiceImpl.java:767)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:158)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:135)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:145)
	at com.sun.proxy.$Proxy174.initEAR(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.initEAR(PortletLocalServiceUtil.java:3...
      2. PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1528887788506.log:
!SESSION 2018-06-13 11:06:22.293 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.portal.upgrade.impl 4 0 2018-06-13 11:06:22.293
        
!MESSAGE Invocation to listener threw exception
        
!STACK 0
        
com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.kernel.upgrade.UpgradeException: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table 'lportal.Lock_' doesn't exist
        
at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:97)
        
at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:133)
        
at com.liferay.portal.upgrade.internal.release.osgi.commands.ReleaseManagerOSGiCommands$UpgradeInfosRunnable.run(ReleaseManagerOSGiCommands.java:540)
        
at com.liferay.portal.output.stream.container.internal.OutputStreamContainerFactoryTrackerImpl.runWithSwappedLog(OutputStreamContainerFactoryTrackerImpl.java:117)
        
at com.liferay.portal.upgrade.internal.release.osgi.commands.ReleaseManagerOSGiCommands.executeUpgradeInfos(ReleaseManagerOSGiCommands.java:338)
        
at com.liferay.portal.upgrade.internal.release.osgi.commands.ReleaseManagerOSGiCommands.doExecute(ReleaseManagerOSGiCommands.java:281)
        
at com.liferay.portal.u...
  4. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    6 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #240324
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
        
com.liferay.portal.kernel.xml.DocumentException: Error on line 42 of document  : A ')' is required in the declaration of element type "portlet". Nested exception: A ')' is required in the declaration of element type "portlet".
        
at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:408)
        
at com.liferay.portal.xml.SAXReaderImpl.read(SAXReaderImpl.java:426)
        
at com.liferay.portal.kernel.xml.UnsecureSAXReaderUtil.read(UnsecureSAXReaderUtil.java:74)
        
at com.liferay.portal.service.impl.PortletLocalServiceImpl.readLiferayPortletXML(PortletLocalServiceImpl.java:2090)
        
at com.liferay.portal.service.impl.PortletLocalServiceImpl.initEAR(PortletLocalServiceImpl.java:767)
        
at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:158)
        
at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
        
at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:135)
        
at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:145)
        
at com.sun.proxy.$Proxy172.initEAR(Unknown Source)
        
at com.liferay.portal.kernel.service.PortletLocalServiceUtil.initEAR(PortletLocalServiceUtil.java:3...
  5. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #220246
           [echo] -		<property access="com.liferay.portal.dao.orm.hibernate.LiferayPropertyAccessor" name="dueDate" type="org.hibernate.type.TimestampType" />
      
[echo] -		<property access="com.liferay.portal.dao.orm.hibernate.LiferayPropertyAccessor" name="finishDate" type="org.hibernate.type.TimestampType" />
      
[echo] -		<property access="com.liferay.portal.dao.orm.hibernate.LiferayPropertyAccessor" name="status" type="com.liferay.portal.dao.orm.hibernate.IntegerType" />
      
[echo] +		<property name="groupId" type="com.liferay.portal.dao.orm.hibernate.LongType" />
      
[echo] +		<property name="companyId" type="com.liferay.portal.dao.orm.hibernate.LongType" />
      
[echo] +		<property name="userId" type="com.liferay.portal.dao.orm.hibernate.LongType" />
      
[echo] +		<property name="userName" type="com.liferay.portal.dao.orm.hibernate.StringType" />
      
[echo] +		<property name="createDate" type="org.hibernate.type.TimestampType" />
      
[echo] +		<property name="modifiedDate" type="org.hibernate.type.TimestampType" />
      
[echo] +		<property name="title" type="com.liferay.portal.dao.orm.hibernate.StringType" />
      
[echo] +		<property name="priority" type="com.liferay.portal.dao.orm.hibernate.IntegerType" />
      
[echo] +		<property name="assigneeUserId" type="com.liferay.portal.dao.orm.hibernate.LongType" />
      
[echo] +		<property name="resolverUserId" type="com.liferay.portal.dao.orm.hibernate.LongType" />
      
[echo] +		<property name="dueDate" type="org.hibernate.type.TimestampType" />
      
[echo] +		<property name="finishDate" type="org.hibernate.type.TimestampType" />
      
[echo] +		<property name="status" type="com.liferay.portal.dao.orm.hibernate.IntegerType" />
      
[echo]  	</class>
      
[echo]  </hibernate-mapping>
      
[echo] \ No newline at end of file
      
[echo] .
      
[echo]
      
[echo] Detected build services changes. See above build services log for more
      
[echo] information. Make sure to commit in all build services results.
      
[get] Getting: http://test-1-5/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/220246//consoleText
      
[get] To: /opt/dev/projects/github/liferay-portal/20180613110637040.txt
      
[delete] Deleting: /opt/dev/projects/github/liferay-portal/20180613110637040.txt
      
[delete] Deleting: /opt/dev/projects/github/liferay-portal/null2126295752.properties

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test - missing ci:test:relevant - failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ealonso @liferay-continuous-integration @brianchandotcom