LPS-83974 SF sort #61823

csierra · 2018-08-02T09:29:03Z

ServiceReference's are mutable structures. Storing them inside ordered structured, such as TreeSet, can lead to duplications or unreachability if the structures are mutated after they have been inserted and the mutation affects the relative order inside the stucture. This change uses unordered lists and creates ordered snapshots when needed.

…id used as tie breaker + unregister services to not taint other tests

…ice.ranking & service.id correctly when services come and go

liferay-continuous-integration · 2018-08-02T09:29:06Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

csierra · 2018-08-02T09:29:23Z

ci:test

liferay-continuous-integration · 2018-08-02T09:30:49Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 30 seconds 940 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c8d9304a972a868a6e3b940c9cb011d755c68a0a

Sender Branch:

Branch Name: pr-438
Branch GIT ID: b313fde1578dadab0c3244e9b9de887df86b900f

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2018-08-02T10:23:05Z

✔️ ci:test:relevant - 19 out of 19 jobs passed in 53 minutes 41 seconds 965 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7522ba6089354225ead164c07fa79eb87735e3c5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9ddf558ed78e4fdd7985f7bfac6318297205d1b3

19 out of 19 jobs PASSED

19 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2018-08-02T12:02:45Z

❌ ci:test - 172 out of 176 jobs passed in 2 hours 32 minutes 51 seconds 779 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7522ba6089354225ead164c07fa79eb87735e3c5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9ddf558ed78e4fdd7985f7bfac6318297205d1b3

172 out of 176 jobs PASSED

4 Failed Jobs:

172 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle121-jdk8

Job Results:

9222 Tests Passed.
35 Tests Failed.

AXIS_VARIABLE=3,label_exp=!master #235995

BlogsTrackbacksVerifyProcessTest.classMethod

java.lang.RuntimeException: Arquillian has previously been attempted initialized, but failed. See cause for previous exception
	at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:106)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
	at com.sun.proxy.$Proxy3.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorke...

BlogsPortletDataHandlerTest.classMethod

org.jboss.arquillian.container.spi.client.container.LifecycleException: Cannot start Karaf container
	at org.jboss.arquillian.container.osgi.karaf.remote.KarafRemoteDeployableContainer.start(KarafRemoteDeployableContainer.java:105)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:199)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:163)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:157)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.forContainer(ContainerLifecycleController.java:255)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.startContainer(ContainerLifecycleController.java:156)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:99)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:81)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.create...

BookmarksEntryStagedModelDataHandlerTest.classMethod

java.lang.RuntimeException: Arquillian has previously been attempted initialized, but failed. See cause for previous exception
	at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:106)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
	at com.sun.proxy.$Proxy3.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorke...

...

Failures in common with acceptance upstream results at c8d9304:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/25
Job Results:
26 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #214770
  1. LocalFile.CPRolesCPWebcontent#AddWebContentSiteRoleDefaultPermission - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle121-jdk8

Job Results:

9222 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=3,label_exp=!master #235995

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
HikariPool-1 - Exception during pool initialization.
java.sql.SQLRecoverableException: IO Error: Connection reset
	at oracle.jdbc.driver.T4CConnection.logon(T4CConnection.java:682)
	at oracle.jdbc.driver.PhysicalConnection.<init>(PhysicalConnection.java:711)
	at oracle.jdbc.driver.T4CConnection.<init>(T4CConnection.java:385)
	at oracle.jdbc.driver.T4CDriverExtension.getConnection(T4CDriverExtension.java:30)
	at oracle.jdbc.driver.OracleDriver.connect(OracleDriver.java:558)
	at com.zaxxer.hikari.util.DriverDataSource.getConnection(DriverDataSource.java:112)
	at com.zaxxer.hikari.util.DriverDataSource.getConnection(DriverDataSource.java:118)
	at com.zaxxer.hikari.pool.PoolBase.newConnection(PoolBase.java:358)
	at com.zaxxer.hikari.pool.PoolBase.newPoolEntry(PoolBase.java:201)
	at com.zaxxer.hikari.pool.HikariPool.createPoolEntry(HikariPool.java:443)
	at com.zaxxer.hikari.pool.HikariPool.checkFailFast(HikariPool.java:514)
	at com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:111)
	at com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:97)
	at com.liferay.portal.spring.hibernate.DialectDetector.getDialect(DialectDetector.java:52)
	at com.liferay.portal.dao.jdbc.DataSourceFactoryImpl.initDataSource(DataSourceFactoryImpl.java:205)
	at com.liferay.portal.kernel.dao.jdbc.DataSourceFactoryUtil.initDataSource(DataSourceFactoryUtil.java:39)
	at com.liferay.portal.dao.jdbc.spring.DataSourceFactoryBean.createInstance(Data...

test-portal-acceptance-pullrequest-batch(master)/tck-jdk8

Job Results:

622 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #200699

CheckResourceURLNotChangePortletModeTest.test


Test case throws exception: [BasePortletUrlClient] CheckResourceURLNotChangePortletModeTest failed! Test FAILED!

ResourceURLAppendParameterTest.test


Test case throws exception: [BasePortletUrlClient] ResourceURLAppendParameterTest failed! Test FAILED!

csierra · 2018-08-02T12:05:05Z

ci:test

liferay-continuous-integration · 2018-08-02T15:02:41Z

❌ ci:test - 171 out of 176 jobs passed in 2 hours 48 minutes 35 seconds 937 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7522ba6089354225ead164c07fa79eb87735e3c5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9ddf558ed78e4fdd7985f7bfac6318297205d1b3

171 out of 176 jobs PASSED

5 Failed Jobs:

171 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/24
Job Results:
3 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=3,label_exp=!master #96788
  Build was aborted
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/28
Job Results:
22 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #169563
  1. LocalFile.WorkflowWiki#ApproveFrontPageUserEdit - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 7522ba6:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/25
Job Results:
26 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #250987
  1. LocalFile.CPRolesCPWebcontent#AddWebContentSiteRoleDefaultPermission - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/tck-jdk8

Job Results:

622 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #248610

CheckResourceURLNotChangePortletModeTest.test


Test case throws exception: [BasePortletUrlClient] CheckResourceURLNotChangePortletModeTest failed! Test FAILED!

ResourceURLAppendParameterTest.test


Test case throws exception: [BasePortletUrlClient] ResourceURLAppendParameterTest failed! Test FAILED!

brianchandotcom · 2018-08-02T18:18:57Z

Merged. Thx.

brianchandotcom · 2018-08-02T18:20:32Z

@csierra can you rename "services" to "trackedOnes" and then send this to @shuyangzhou? Thx.

csierra · 2018-08-03T10:04:40Z

please see shuyangzhou#6568

Carlos Sierra and others added 5 commits July 30, 2018 18:51

LPS-83974 Add tests to show bug

914f2ba

LPS-83974 Test that default service.ranking is respected and service.…

bb71cac

…id used as tie breaker + unregister services to not taint other tests

LPS-83974 Similar tests to ensure ServiceTrackerMap also handles serv…

97d2741

…ice.ranking & service.id correctly when services come and go

LPS-83974 SF sort

b313fde

csierra mentioned this pull request Aug 2, 2018

LPS-83974 Strengthened tests for ServiceTrackerMap csierra/liferay-portal#438

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test - pending ci:test:sf - success and removed ci:test:relevant - pending ci:test:sf - pending labels Aug 2, 2018

liferay-continuous-integration added the ci:test:relevant - success label Aug 2, 2018

liferay-continuous-integration added ci:test - failure and removed ci:test - pending ci:test:relevant - success ci:test:sf - success labels Aug 2, 2018

liferay-continuous-integration added ci:test - pending ci:test - failure and removed ci:test - failure ci:test - pending labels Aug 2, 2018

brianchandotcom closed this Aug 2, 2018

csierra mentioned this pull request Aug 3, 2018

LPS-83974 SF rename shuyangzhou/liferay-portal#6568

Closed

LPS-83974 SF sort #61823

LPS-83974 SF sort #61823

Conversation

csierra commented Aug 2, 2018

liferay-continuous-integration commented Aug 2, 2018

csierra commented Aug 2, 2018

liferay-continuous-integration commented Aug 2, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 30 seconds 940 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Aug 2, 2018

✔️ ci:test:relevant - 19 out of 19 jobs passed in 53 minutes 41 seconds 965 ms

Base Branch:

Copied in Private Modules Branch:

For more details click here.

liferay-continuous-integration commented Aug 2, 2018

❌ ci:test - 172 out of 176 jobs passed in 2 hours 32 minutes 51 seconds 779 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

csierra commented Aug 2, 2018

liferay-continuous-integration commented Aug 2, 2018

❌ ci:test - 171 out of 176 jobs passed in 2 hours 48 minutes 35 seconds 937 ms

Base Branch:

Copied in Private Modules Branch:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

brianchandotcom commented Aug 2, 2018

brianchandotcom commented Aug 2, 2018

csierra commented Aug 3, 2018