New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-86079 Add the Aries CDI implementation #63938
Conversation
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 42 seconds 542 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-85319 1 Successful Jobs:For more details click here. |
/cc @ngriffin7a |
Unable to generate test report.Jenkins encountered the following error while generating test report:
Base Branch:Branch Name: master Branch GIT ID: 501d1401c27e2acda72c40222a24311439ac257f Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
ci:test:relevant |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed:
For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/16Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/17Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/19Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/23Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/24Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/25Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/37Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/40Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/41Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/48Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/54Job Results:0 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55Job Results:0 Tests Passed.
|
❌ ci:test:relevant - 9 out of 75 jobs passed in 2 hours 51 minutes 42 seconds 898 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 66 Failed Jobs:
9 Successful Jobs:
For more details click here.Failures unique to this pull:
For upstream results, click here. |
@rotty3000 Did you happen to send a follow-up PR? |
about 200 hundred actually :)
The current one is this:
#64093
…On Fri, Oct 12, 2018 at 11:07 AM Neil Griffin ***@***.***> wrote:
@rotty3000 <https://github.com/rotty3000> Did you happen to send a
follow-up PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI9TBznDhQMbrDZrBigRItsz9N-rVdQks5ukLApgaJpZM4XTdaR>
.
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
(@liferay)
Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
|
OK thanks. I'm subscribed to it. |
Actually #64093 is for LPS-86015 but this one was for LPS-86079. Are you resending one for LPS-86079? |
oh yeah, like I said, I've been sending PRs hard and fast... Right now
there are a few different PRs, but the one that has everything, as a test
to iron out CI issues is this one
#64133
…On Sat, Oct 13, 2018 at 7:20 PM Neil Griffin ***@***.***> wrote:
Actually #64093
<#64093> is for
LPS-86015 but this one was for LPS-86079. Are you resending one for
LPS-86079?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI9TIXGqkSW7MA0OJPW7ycSXYQUL4qNks5uknVQgaJpZM4XTdaR>
.
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
(@liferay)
Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
|
Basically you want to look at my branch here
https://github.com/rotty3000/liferay-portal/tree/LPS-85319 for the latest
On Sat, Oct 13, 2018 at 7:49 PM Raymond Auge <raymond.auge@liferay.com>
wrote:
… oh yeah, like I said, I've been sending PRs hard and fast... Right now
there are a few different PRs, but the one that has everything, as a test
to iron out CI issues is this one
#64133
On Sat, Oct 13, 2018 at 7:20 PM Neil Griffin ***@***.***>
wrote:
> Actually #64093
> <#64093> is for
> LPS-86015 but this one was for LPS-86079. Are you resending one for
> LPS-86079?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#63938 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAI9TIXGqkSW7MA0OJPW7ycSXYQUL4qNks5uknVQgaJpZM4XTdaR>
> .
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
***@***.***)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
***@***.***)
Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org>
***@***.***)
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
(@liferay)
Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
|
No description provided.