Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lps 86036 #65317

Closed
wants to merge 26 commits into from
Closed

Lps 86036 #65317

wants to merge 26 commits into from

Conversation

shuyangzhou
Copy link

No description provided.

lanceji92674957 and others added 26 commits November 26, 2018 10:36
@lanceji92674957 @shuyangzhou
LPS-86036 Default value of _supportsStringCaseSensitiveQuery is true,…
4b262af 
… no need to mock
@lanceji92674957 @shuyangzhou
LPS-86036 No need to use mock, returning null is default behavior of …
b212a9e 
…simple mock
@lanceji92674957 @shuyangzhou
LPS-86036 Remove mocks not used in test logic, the methods we mocked …
b26ff94 
…are not invoked at all while tests are running, thus no need to mock.
@lanceji92674957 @shuyangzhou
LPS-86036 Remove mock that does not do anything
0fe8c30
@lanceji92674957 @shuyangzhou
LPS-86036 Organize setup methods for group
0dbeea0
@lanceji92674957 @shuyangzhou
LPS-86036 Use serviceWrapper to replace service mock, additional meth…
13687a1 
…ods added to avoid NPE
@lanceji92674957 @shuyangzhou
LPS-86036 Use simple setter instead of mocking methods
9a70f9c
@lanceji92674957 @shuyangzhou
LPS-86036 No need to use field method in Powermock, use ReflectionTes…
3653b52 
…tUtil instead
@lanceji92674957 @shuyangzhou
LPS-86036 Use ReflectionTestUtil to set field value instead of using …
13a77b0 
…mock
@lanceji92674957 @shuyangzhou
LPS-86036 Use serviceWrapper to provide intended service functions in…
b5743f8 
…stead of mocking util method
@lanceji92674957 @shuyangzhou
LPS-86036 Replace simple mock with dummyProxyInstance
2fd7607
@lanceji92674957 @shuyangzhou
LPS-86036 Inline methods
6481ccd
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by using PropsUtil.set
860459d
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by dummy proxy, dummy proxy will return null …
c9e042a 
…when method is invoked.
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by extending class
d32beee
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by extending warpper
25851f9
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by using BasicRegistryImpl
e0a2d0b
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by not using DDMStructure. Compose test class…
cd67a92 
…es to do same thing as DDMStructure does. See https://issues.liferay.com/browse/LPS-41401 for more details.
@tinatian @shuyangzhou
LPS-86036 Avoid mocking by using real instance
767c444
@lanceji92674957 @shuyangzhou
LPS-86036 Remove duplicated setter, since it is already set by base c…
d873e44 
…lass
@tinatian @shuyangzhou
LPS-86036 Remove unused class
b4a4c31
@tinatian @shuyangzhou
LPS-86036 Extend class to achieve same goal, so that we can inline me…
0ce70f0 
…thod
@tinatian @shuyangzhou
LPS-86036 SF, no need to define variable
b854ef8
@tinatian @shuyangzhou
LPS-86036 Setup once per class rather than per test method
9d79267
@tinatian @shuyangzhou
LPS-86036 No need to do this cause we always use a new jvm process to…
0b40574 
… run a unit test
@tinatian @shuyangzhou
LPS-86036 SF, move same logic into private method
f5ce270
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@shuyangzhou shuyangzhou mentioned this pull request Nov 26, 2018
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 45 seconds 835 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b45ed84a14cac0590bd0c655ee7dfc6f76c3ce52

Sender Branch:

Branch Name: LPS-86036
Branch GIT ID: f5ce27031c2930de95209f85dedce5276979f55b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 460761f...6aa8508

@brianchandotcom
Copy link
Owner

@tinatian @lanceji92674957 backported to 7.1.x.

@brianchandotcom
Copy link
Owner

@tinatian can you communicate to @hhuijser the rules? It seems patternable that we can stop developers from doing in the future.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:relevant - 80 out of 80 jobs passed in 2 hours 1 minute 17 seconds 566 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b45ed84a14cac0590bd0c655ee7dfc6f76c3ce52

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 21d37ccb5b28143b3ad6c5df9e70d56d054bfd0a

80 out of 80 jobs PASSED
80 Successful Jobs:
For more details click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuyangzhou @liferay-continuous-integration @brianchandotcom @lanceji92674957 @tinatian