Lps 88361 #65819

shuyangzhou · 2018-12-11T23:37:41Z

@brianchandotcom after this pull, we are technically done, as we no longer use any Struts binaries.
But the struts name is still all over our codebase. To clean them up may still take a while. Because a lot of them can actually be removed or at least rewrite in some different ways. I want to clean them up in the right way rather than just rename them.

Another thing is, quite a few "Struts" naming classes are in exported packages, renaming them will cause major version bump. I just want to confirm we are willing to pay the major version bump price to get rid of the struts footprints, right?

CC @mhan810

…we must have a ActionMapping or strutsAction, they can not be both missing.

… is always an exact match.

…we must have a ActionMapping or strutsAction, they can not be both missing. So actionMapping is impossible to be null here.

…nalAction(), so that we don't need to do a refetch in _processActionCreate

…are not used.

…tion, better to drop support of it to keep design simple.

…sp.jsp", there is no need of the map.

…ot be used.

…, so that we don't need StrutsPortletFindActionHelper and BaseStrutsPortletFindActionHelper anymore

…but this usage here does not set a struts_action, switch to use base class

liferay-continuous-integration · 2018-12-11T23:37:44Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2018-12-11T23:40:36Z

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 28 seconds 936 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e48446d9c2cfc8d58b134bd1be5474248c082111

Sender Branch:

Branch Name: LPS-88361
Branch GIT ID: d08612ba2063b009a8b43e2c858c3c1262465de9

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./portal-impl/src/com/liferay/portal/security/permission/ResourceActionsImpl.java expected:<....http.HttpSession;
     [java] 
     [java] []/**
     [java]  * @author Brian...> but was:<....http.HttpSession;
     [java] 
     [java] [
     [java] ]/**
     [java]  * @author Brian...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:412)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:239)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:673: Java returned: 1
      [get] Getting: http://test-1-19/job/test-portal-source-format/1027//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20181211234025931.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20181211234025931.txt
  [taskdef] Could not load definitions from resource aQute/bnd/ant/taskdef.properties. It could not be found.
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null898261916.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null1655308345

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 237ms

[junitreport] Deleting: /tmp/null1655308345

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

[echo] Memory: 4k page, physical 16777216k(5935352k free), swap 2097152k(1316372k free)

liferay-continuous-integration · 2018-12-11T23:40:40Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-source-format

@shuyangzhou

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

test-portal-source-format

For information as to why we automatically close out certain pull requests see this article.

*If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

*The reopened pull request may be automatically closed again if other critical batches or tests fail.

Critical Failure Details:

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 33 seconds 531 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e48446d9c2cfc8d58b134bd1be5474248c082111

Sender Branch:

Branch Name: LPS-88361
Branch GIT ID: d08612ba2063b009a8b43e2c858c3c1262465de9

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./portal-impl/src/com/liferay/portal/security/permission/ResourceActionsImpl.java expected:<....http.HttpSession;
     [java] 
     [java] []/**
     [java]  * @author Brian...> but was:<....http.HttpSession;
     [java] 
     [java] [
     [java] ]/**
     [java]  * @author Brian...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:412)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:239)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:673: Java returned: 1
      [get] Getting: http://test-1-19/job/test-portal-source-format/1027//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20181211234025931.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20181211234025931.txt
  [taskdef] Could not load definitions from resource aQute/bnd/ant/taskdef.properties. It could not be found.
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null898261916.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null1655308345

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 237ms

[junitreport] Deleting: /tmp/null1655308345

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

[echo] Memory: 4k page, physical 16777216k(5935352k free), swap 2097152k(1316372k free)

cc @jpince

brianchandotcom · 2018-12-11T23:41:05Z

@shuyangzhou can you resend? Thx.

shuyangzhou · 2018-12-11T23:44:35Z

Sorry, fixed SF, resent here #65820

liferay-continuous-integration · 2018-12-12T00:05:58Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 1 minute 10 seconds 889 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e48446d9c2cfc8d58b134bd1be5474248c082111

Copied in Private Modules Branch:

Branch Name:

0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

0 Jobs Passed.
1 Job Failed.

A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

For upstream results, click here.

shuyangzhou added 30 commits December 11, 2018 15:32

LPS-88361 No one is using this getModuleConfig()

c99e038

LPS-88361 No one reads Globals.MODULE_KEY

4ff1c1d

LPS-88361 Use actual type to reduce struts type denpendency

0977b18

LPS-88361 We don't have any unknown ActionConfig

bfdd84d

LPS-88361 Register/unregister the PortletTCKStrutsAction directly.

7b7ce05

LPS-88361 Remove unused methods

202044f

LPS-88361 _findPath can not return null value.

944a061

LPS-88361 Avoid duplicated path finding

f17fbca

LPS-88361 The top level process() already ensured, for a given path, …

9bb0341

…we must have a ActionMapping or strutsAction, they can not be both missing.

LPS-88361 We don't have wildcard path usage, so path to actionMapping…

27afd12

… is always an exact match.

LPS-88361 Inline _findMapping()

0288d9e

LPS-88361 Simplify

f256e39

LPS-88361 The path is incapable of being null here.

52e6817

LPS-88361 Pull up _processPath() to caller.

ea8dd51

LPS-88361 Process path earlier

3802c5d

LPS-88361 Simplify

c753c03

LPS-88361 The top level process() already ensured, for a given path, …

a63339c

…we must have a ActionMapping or strutsAction, they can not be both missing. So actionMapping is impossible to be null here.

LPS-88361 Inline _processMapping()

7270672

LPS-88361 Do the place holder ActionMapping checking inside _getOrigi…

b55d5a9

…nalAction(), so that we don't need to do a refetch in _processActionCreate

LPS-88361 Simplify

f683f6c

LPS-88361 Create our model classes to replace struts ones.

16909b6

LPS-88361 Apply new model classes globally

0eb45f1

LPS-88361 JSONAction.getJSON() never uses ActionMapping

714182c

LPS-88361 Globals.ACTION_SERVLET_KEY and Globals.MODULE_PREFIXES_KEY …

b7a5bf6

…are not used.

LPS-88361 Create WebKeys.SERVLET_MAPPING to replace Globals.SERVLET_KEY

dc84d47

LPS-88361 Replace Globals.LOCALE_KEY with WebKeys.LOCALE

510f434

LPS-88361 SF exclude

3363e74

LPS-88361 No one is using StrutsUtil.STRUTS_PACKAGE

82e15e3

LPS-88361 This can no longer work as struts jar is going to be removed

1712bad

LPS-88361 Drop SampleStrutsWab testing.

5e1854b

shuyangzhou added 17 commits December 11, 2018 15:32

LPS-88361 We never have an usecase that delegates to originalStrutsAc…

11cdcd5

…tion, better to drop support of it to keep design simple.

LPS-88361 Merge StrutsActionRegistryUtil into ModuleConfig

5cf7b83

LPS-88361 Avoid unnecessary refetch

5456e7b

LPS-88361 Use default method to eliminate the needs of BaseStrutsAction

0a4168f

LPS-88361 Apply usage

1d23f1b

LPS-88361 The only key we ever get from the map is "/common/referer_j…

6f92e91

…sp.jsp", there is no need of the map.

LPS-88361 Drop StrutsURLEncoder support

d56dd15

LPS-88361 Remove dead code, this is not registered anywhere, it can n…

774ff05

…ot be used.

LPS-88361 Not used anymore

56a2642

LPS-88361 Push down the struts_action populating to actual subclasses…

b61100c

…, so that we don't need StrutsPortletFindActionHelper and BaseStrutsPortletFindActionHelper anymore

LPS-88361 Default to return portletURL

e63c53a

LPS-88361 Decouple FindStrutsAction from BaseFindActionHelper

9fe55ea

LPS-88361 Merge FindActionHelper into FindStrutsAction

a5eb27e

LPS-88361 StrutsActionPortletURL intercepts struts_action parameter, …

3e672d6

…but this usage here does not set a struts_action, switch to use base class

LPS-88361 No longer used

780e8b8

LPS-88361 Simple enough base template logic, push down to subclasses.

c625a15

LPS-88361 Semantic versioning

d08612b

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Dec 11, 2018

liferay-continuous-integration closed this Dec 11, 2018

liferay-continuous-integration added ci:test:relevant - pending ci:test:relevant - failure and removed ci:test:relevant - pending labels Dec 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lps 88361 #65819

Lps 88361 #65819

shuyangzhou commented Dec 11, 2018

liferay-continuous-integration commented Dec 11, 2018

liferay-continuous-integration commented Dec 11, 2018

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Dec 11, 2018

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

brianchandotcom commented Dec 11, 2018

shuyangzhou commented Dec 11, 2018

liferay-continuous-integration commented Dec 12, 2018

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

Lps 88361 #65819

Lps 88361 #65819

Conversation

shuyangzhou commented Dec 11, 2018

liferay-continuous-integration commented Dec 11, 2018

liferay-continuous-integration commented Dec 11, 2018

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 28 seconds 936 ms

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Dec 11, 2018

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 33 seconds 531 ms

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

brianchandotcom commented Dec 11, 2018

shuyangzhou commented Dec 11, 2018

liferay-continuous-integration commented Dec 12, 2018

❌ ci:test:relevant - 0 out of 1 jobs passed in 1 minute 10 seconds 889 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.