Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-88428 LPS-86086 LPS-86087 Search API: Search Request, Search Response + Search Insights Widget: Explain, Response String #66040

Conversation

arboliveira
Copy link

DO NOT BACKPORT (STORY)

❌ ci:test:search - 15 out of 17 jobs passed in 1 hour 17 minutes 22 seconds 861 ms
(arboliveira#638 (comment))

Test failure is a known unrelated problem:

ClassicSearch#SearchByAssetAndModifiedRangeFacets - Issue clicking publish for Wiki
(xbrianlee#240 (comment))

Authors: @wcao20170619 @arboliveira
Reviewers: @arboliveira @rbohl

[Story] As a Developer, I can build a SearchRequest and obtain a SearchResponse
https://issues.liferay.com/browse/LPS-88428

[Story] Search Insights Widget: Explain
https://issues.liferay.com/browse/LPS-86086

[Story] Search Insights Widget: Search Response String
https://issues.liferay.com/browse/LPS-86087

arboliveira and others added 12 commits December 18, 2018 17:25
…sponse

+ New feature: explain
+ New feature: include the response string

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…g alongside Request String

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
… String

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…rchContext

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…, Response String

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…onse String

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…e String

https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
https://issues.liferay.com/browse/LPS-88428

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…g, Response String

https://issues.liferay.com/browse/LPS-86087

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…ing, Response String

https://issues.liferay.com/browse/LPS-86087

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
https://issues.liferay.com/browse/LPS-86087

Co-authored-by: Russell Bohl <russell.bohl@liferay.com>
Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
https://issues.liferay.com/browse/LPS-86087

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 5 seconds 522 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bc30ccdd099178ebae0bc715deda69575f25eaf7

Sender Branch:

Branch Name: LPS-86087-SearchInsights-Explain-ResponseString
Branch GIT ID: a3da31ba6442d56082f9b6ad6af0862c787bb420

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:relevant - 27 out of 27 jobs passed in 1 hour 7 minutes 14 seconds 878 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bc30ccdd099178ebae0bc715deda69575f25eaf7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: dc1cc98a6af7bfefddc04679289fb54c1fabe908

27 out of 27 jobs PASSED
27 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 437ecb8...b3cfd93

@brianchandotcom
Copy link
Owner

@arboliveira merged, I did NOT backport.

Going fwd, I will not backport search stuff. You guys need to send it to 7.0.x and 7.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants