Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-91526 Set tag as request attribute for all IncludeTags. This help… #68914

Closed
wants to merge 1 commit into from
Closed

LPS-91526 Set tag as request attribute for all IncludeTags. This help… #68914

wants to merge 1 commit into from

Conversation

shuyangzhou
Copy link

…s preserve backwards compatibility with tag hooks.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@shuyangzhou shuyangzhou mentioned this pull request Mar 4, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 5 seconds 317 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 54276b19e1405b5c06b45baab5b6f9d2220ede58

Sender Branch:

Branch Name: LPS-91526
Branch GIT ID: fb651c0d531f0b98ec176e13857958267912b003

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@Preston-Crary @shuyangzhou
LPS-91526 Set tag as request attribute for all IncludeTags. This help…
fb651c0 
…s preserve backwards compatibility with tag hooks.
@brianchandotcom
Copy link
Owner

Merged. Thx.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 7 out of 20 jobs passed in 1 hour 24 minutes 45 seconds 382 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 54276b19e1405b5c06b45baab5b6f9d2220ede58

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: bb05b18168fd1ff84bb232f565de282ff8c473b8

7 out of 20 jobs PASSED

13 Failed Jobs:

7 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at f31d742:
  1. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
    Job Results:

    1 Test Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #148485
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Failed to install artifact: /opt/dev/projects/github/liferay-portal/bundles/osgi/configs/com.liferay.headless.collaboration.oauth2.rest.provider.rest.jaxrs.feature.configuration..ConfigurableScopeCheckerFeatureConfiguration.config 
java.io.IOException: Unexpected token 34; expected: 61 (line=16, pos=84)
	at org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:650)
	at org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:274)
	at org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:237)
	at org.apache.felix.fileinstall.internal.ConfigInstaller.setConfig(ConfigInstaller.java:237)
	at org.apache.felix.fileinstall.internal.ConfigInstaller.install(ConfigInstaller.java:78)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.port...</code></pre></div></li><li><div><a href="https://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/148485//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanOSGiLog">PortalLogAssertorTest.testScanOSGiLog</a><pre><code>junit.framework.AssertionFailedError: 

        

        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1551744496566.log:
        
!SESSION 2019-03-05 00:08:25.580 -----------------------------------------------
        
eclipse.buildId=unknown
        
java.version=11.0.1
        
java.vendor=Oracle Corporation
        
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY org.apache.felix.fileinstall 4 0 2019-03-05 00:08:25.580
        
!MESSAGE Failed to install artifact: /opt/dev/projects/github/liferay-portal/bundles/osgi/configs/com.liferay.headless.collaboration.oauth2.rest.provider.rest.jaxrs.feature.configuration..ConfigurableScopeCheckerFeatureConfiguration.config
        
!STACK 0
        
java.io.IOException: Unexpected token 34; expected: 61 (line=16, pos=84)
        
at org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:650)
        
at org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:274)
        
at org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.setConfig(ConfigInstaller.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.install(ConfigInstaller.java:78)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher....
  2. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
    Job Results:

    1 Test Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #275796
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
Failed to install artifact: /opt/dev/projects/github/liferay-portal/bundles/osgi/configs/com.liferay.headless.collaboration.oauth2.rest.provider.rest.jaxrs.feature.configuration..ConfigurableScopeCheckerFeatureConfiguration.config
        
java.io.IOException: Unexpected token 34; expected: 61 (line=16, pos=84)
        
at org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:650)
        
at org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:274)
        
at org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.setConfig(ConfigInstaller.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.install(ConfigInstaller.java:78)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)
        

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.port...</code></pre></div></li><li><div><a href="https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/275796//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanOSGiLog">PortalLogAssertorTest.testScanOSGiLog</a><pre><code>junit.framework.AssertionFailedError: 

        

        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1551743676491.log:
        
!SESSION 2019-03-04 23:54:45.786 -----------------------------------------------
        
eclipse.buildId=unknown
        
java.version=1.8.0_121
        
java.vendor=Oracle Corporation
        
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY org.apache.felix.fileinstall 4 0 2019-03-04 23:54:45.786
        
!MESSAGE Failed to install artifact: /opt/dev/projects/github/liferay-portal/bundles/osgi/configs/com.liferay.headless.collaboration.oauth2.rest.provider.rest.jaxrs.feature.configuration..ConfigurableScopeCheckerFeatureConfiguration.config
        
!STACK 0
        
java.io.IOException: Unexpected token 34; expected: 61 (line=16, pos=84)
        
at org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:650)
        
at org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:274)
        
at org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.setConfig(ConfigInstaller.java:237)
        
at org.apache.felix.fileinstall.internal.ConfigInstaller.install(ConfigInstaller.java:78)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
        
at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatch...
  6. ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuyangzhou @liferay-continuous-integration @brianchandotcom @Preston-Crary