LPS-91645 Build lang #71102

4lejandrito · 2019-04-09T14:00:59Z

No description provided.

The oAuth2Manager will fail if Google Drive is not configured properly.

liferay-continuous-integration · 2019-04-09T14:01:05Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-04-09T14:04:11Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 14 seconds 941 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b1dc6d910793d7d060765479c353852b9ba23a3e

Sender Branch:

Branch Name: pr-241
Branch GIT ID: 891bdd42bb522df245162c8dd05c8644748a58f0

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

4lejandrito · 2019-04-09T14:05:41Z

Hi @brianchandotcom,,

Are you sure about this sentence?

Wouldn't Lists third party apps... be more correct? In any case I think List of third party apps... describes much better what goes below.

Thanks!

adolfopa · 2019-04-09T14:38:53Z

Hey @brianchandotcom

About moving the Connected Apps classes in Sharepoint and Google to their own modules, I haven't included that in this PR. The problem is that the Google Connected App depends on some internal classes in the Google Drive Web module. Moving that out would require us to expose some implementation details (mainly the OAuth2Manager), and we'd prefer not to. The Sharepoint one doesn't have this problem, so in this case there's no problem.

Let me know if you think we should move forward with this, or if we keep it as it is right now.

Thanks!

liferay-continuous-integration · 2019-04-09T15:48:19Z

❌ ci:test:relevant - 10 out of 27 jobs passed in 1 hour 43 minutes 46 seconds 107 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b1dc6d910793d7d060765479c353852b9ba23a3e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 4ef84f54b82390fe54e3f77dd8bb1332e4f985bf

10 out of 27 jobs PASSED

17 Failed Jobs:

10 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at b1dc6d9:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #247003

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
bundle com.liferay.change.tracking.change.lists.web:1.0.0 (418)[com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter(1835)] : The activate method has thrown an exception 
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
	at java.base/java.util.concurrent.CopyOnWriteArrayList.elementAt(CopyOnWriteArrayList.java:386)
	at java.base/java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:399)
	at com.liferay.registry.collections.ServiceTrackerCollections$ServiceTrackerCollectionImpl.get(ServiceTrackerCollections.java:413)
	at com.liferay.portal.kernel.settings.SettingsLocatorHelperUtil.getSettingsLocatorHelper(SettingsLocatorHelperUtil.java:55)
	at com.liferay.portal.kernel.settings.SystemSettingsLocator.<init>(SystemSettingsLocator.java:39)
	at com.liferay.portal.configuration.module.configuration.internal.ConfigurationProviderImpl.getSystemConfiguration(ConfigurationProviderImpl.java:182)
	at com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter.activate(ChangeTrackingThreadLocalSetter.java:38)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.apache.felix.scr.impl.inject.m...

PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1554821174161.log: !SESSION 2019-04-09 14:46:47.089 ----------------------------------------------- eclipse.buildId=unknown java.version=11.0.1 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

!ENTRY com.liferay.change.tracking.change.lists.web 4 0 2019-04-09 14:46:47.090 !MESSAGE bundle com.liferay.change.tracking.change.lists.web:1.0.0 (418)[com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter(1835)] : The activate method has thrown an exception !STACK 0 java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0 at java.base/java.util.concurrent.CopyOnWriteArrayList.elementAt(CopyOnWriteArrayList.java:386) at java.base/java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:399) at com.liferay.registry.collections.ServiceTrackerCollections$ServiceTrackerCollectionImpl.get(ServiceTrackerCollections.java:413) at com.liferay.portal.kernel.settings.SettingsLocatorHelperUtil.getSettingsLocatorHelper(SettingsLocatorHelperUtil.java:55) at com.liferay.portal.kernel.settings.SystemSettingsLocator.<init>(SystemSettingsLocator.java:39) at com.liferay.portal.configuration.module.configuration.internal.ConfigurationProviderImpl.getSystemConfiguration(ConfigurationProviderImpl.java:182) at com.liferay.change.tracking.change....

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #157022

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

bundle com.liferay.change.tracking.change.lists.web:1.0.0 (418)[com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter(1835)] : The activate method has thrown an exception

java.lang.ArrayIndexOutOfBoundsException: 0

at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:387)

at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:396)

at com.liferay.registry.collections.ServiceTrackerCollections$ServiceTrackerCollectionImpl.get(ServiceTrackerCollections.java:413)

at com.liferay.portal.kernel.settings.SettingsLocatorHelperUtil.getSettingsLocatorHelper(SettingsLocatorHelperUtil.java:55)

at com.liferay.portal.kernel.settings.SystemSettingsLocator.<init>(SystemSettingsLocator.java:39)

at com.liferay.portal.configuration.module.configuration.internal.ConfigurationProviderImpl.getSystemConfiguration(ConfigurationProviderImpl.java:182)

at com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter.activate(ChangeTrackingThreadLocalSetter.java:38)

at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)

at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)

at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)

at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)

at org.apache.felix.scr.impl.inject...

PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1554821332320.log: !SESSION 2019-04-09 14:49:58.993 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

!ENTRY com.liferay.change.tracking.change.lists.web 4 0 2019-04-09 14:49:58.993 !MESSAGE bundle com.liferay.change.tracking.change.lists.web:1.0.0 (418)[com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter(1835)] : The activate method has thrown an exception !STACK 0 java.lang.ArrayIndexOutOfBoundsException: 0 at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:387) at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:396) at com.liferay.registry.collections.ServiceTrackerCollections$ServiceTrackerCollectionImpl.get(ServiceTrackerCollections.java:413) at com.liferay.portal.kernel.settings.SettingsLocatorHelperUtil.getSettingsLocatorHelper(SettingsLocatorHelperUtil.java:55) at com.liferay.portal.kernel.settings.SystemSettingsLocator.<init>(SystemSettingsLocator.java:39) at com.liferay.portal.configuration.module.configuration.internal.ConfigurationProviderImpl.getSystemConfiguration(ConfigurationProviderImpl.java:182) at com.liferay.change.tracking.change.lists.web.internal.util.ChangeTrackingThreadLocalSetter....

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
1 Test Passed.
4 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #288118
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #305423
  1. LocalFile.PGMediagallery#DeleteFolderDocument - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
1 Test Passed.
5 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #299292
...

brianchandotcom · 2019-04-09T19:19:38Z

Merged. Thank you.
View total diff: 585ddc4...22069e1

adolfopa added 6 commits April 9, 2019 12:26

LPS-93605 On failure, give other connected apps a chance of working

f13ab87

LPS-93605 Remove exception from signature

0c7e4f4

LPS-93605 Move logic inside the manager

1fa40e9

LPS-93605 Make provider work when unconfigured

dc3c447

The oAuth2Manager will fail if Google Drive is not configured properly.

LPS-91645 Make string a proper sentence

04e99bb

LPS-91645 Build lang

891bdd4

4lejandrito mentioned this pull request Apr 9, 2019

LPS-93605 Improve error handling in Connected Apps 4lejandrito/liferay-portal#241

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Apr 9, 2019

liferay-continuous-integration added the ci:test:relevant - pending label Apr 9, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Apr 9, 2019

brianchandotcom closed this Apr 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-91645 Build lang #71102

LPS-91645 Build lang #71102

4lejandrito commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

Base Branch:

Sender Branch:

For more details click here.

4lejandrito commented Apr 9, 2019 •

edited

Loading

adolfopa commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

Base Branch:

Copied in Private Modules Branch:

17 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

brianchandotcom commented Apr 9, 2019

LPS-91645 Build lang #71102

LPS-91645 Build lang #71102

Conversation

4lejandrito commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 14 seconds 941 ms

Base Branch:

Sender Branch:

For more details click here.

4lejandrito commented Apr 9, 2019 • edited Loading

adolfopa commented Apr 9, 2019

liferay-continuous-integration commented Apr 9, 2019

❌ ci:test:relevant - 10 out of 27 jobs passed in 1 hour 43 minutes 46 seconds 107 ms

Base Branch:

Copied in Private Modules Branch:

17 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

brianchandotcom commented Apr 9, 2019

4lejandrito commented Apr 9, 2019 •

edited

Loading