LPS-92219 Make regular users see other group members on autocomplete #71342

adolfopa · 2019-04-11T14:11:24Z

No description provided.

By default, regular (non admin) users don't have the VIEW permission over the User model. This means that the search() method will filter them all out. Keep the current logic for company admins, and let regular users see other users as long as they belong to the same groups.

liferay-continuous-integration · 2019-04-11T14:11:27Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-04-11T14:14:25Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 52 seconds 864 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9669d368bc70d2e0f2feec2626db7673c4d6472c

Sender Branch:

Branch Name: LPS-92219
Branch GIT ID: 8530ce27ac88f670d9a21947b773e7d7764ee2c2

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

adolfopa · 2019-04-11T14:14:45Z

Hey @pei-jung, I've made a little change to the UserLocalService class, adding an overload to searchSocial so that we can sort the autocomplete results.

liferay-continuous-integration · 2019-04-11T15:28:11Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@adolfopa

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/12

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #249936
1. LocalFile.LDAP#ImportLDAPUserWithBlankPassword - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #290537
1. LocalFile.LocalizationWithSites#ViewSiteLocalizationAfterDeletingOriginalLocale - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/16

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #285811
1. LocalFile.WebContentDisplay#AddAudioViaWebContent - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/22

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #293544
1. LocalFile.CPRolesCPWebcontent#AddStructureSiteRoleDefinePermission - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/23

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #306186
1. LocalFile.CPRolesCPDocumentsandmedia#ViewDocumentsAndMediaPortletRegRole - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/34

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #293545
1. LocalFile.CPRolesCPBlogs#ViewBlogsEntryRegRoleInline - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/37

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #306187

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/41

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #293546
1. LocalFile.CPRolesCPWebcontent#AddFolderSiteRoleDefinePermission - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/49

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #44166
1. LocalFile.ContentPagesWithStaging#PublishEditedContentPage - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/61

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #288883
1. LocalFile.FormRules#ConfigureShowRuleUsingAndCondition - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/62

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #200906
1. LocalFile.WorkflowCalendar#ApproveEventWithInvitedUser - Poshi Report - Poshi Summary - Console Output

cc @

liferay-continuous-integration · 2019-04-11T16:36:16Z

❌ ci:test:relevant - 66 out of 88 jobs passed in 2 hours 24 minutes 25 seconds 323 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f3b09b6dad2de323ca061753955681587ad68c8f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3c10d594b06ce7a1bd7f4560a0e5868eb25ab457

66 out of 88 jobs PASSED

22 Failed Jobs:

66 Successful Jobs:

For more details click here.

Failures (upstream comparison is not available):

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/12
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #249936
  1. LocalFile.LDAP#ImportLDAPUserWithBlankPassword - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #288880
  1. LocalFile.CPRolesCPWebcontent#AddTemplateSiteRoleDefaultPermission - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #290537
  1. LocalFile.LocalizationWithSites#ViewSiteLocalizationAfterDeletingOriginalLocale - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/16
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #285811
  1. LocalFile.WebContentDisplay#AddAudioViaWebContent - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/22
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #293544
  1. LocalFile.CPRolesCPWebcontent#AddStructureSiteRoleDefinePermission - Poshi Report - Poshi Summary - Console Output
...

For upstream results, click here.

adolfopa · 2019-04-11T17:17:35Z

ci:reopen

adolfopa · 2019-04-11T17:17:45Z

ci:test:relevant

brianchandotcom · 2019-04-11T17:37:23Z

Merged. Thx.

liferay-continuous-integration · 2019-04-11T19:49:09Z

❌ ci:test:relevant - 67 out of 88 jobs passed in 2 hours 17 minutes 9 seconds 140 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 024be246928da46a934ce2766f47d85aa518407e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3c10d594b06ce7a1bd7f4560a0e5868eb25ab457

67 out of 88 jobs PASSED

21 Failed Jobs:

67 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at f3b09b6:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/12
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #293664
  1. LocalFile.LDAP#ImportLDAPUserWithBlankPassword - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #249991
  1. LocalFile.CPRolesCPWebcontent#AddTemplateSiteRoleDefaultPermission - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #282721
  1. LocalFile.LocalizationWithSites#ViewSiteLocalizationAfterDeletingOriginalLocale - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/16
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #289002
  1. LocalFile.WebContentDisplay#AddAudioViaWebContent - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/22
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #306302
  1. LocalFile.CPRolesCPWebcontent#AddStructureSiteRoleDefinePermission - Poshi Report - Poshi Summary - Console Output
...

adolfopa added 6 commits April 11, 2019 15:45

LPS-92219 Add overload with OrderByComparator

8880446

LPS-92219 Autogenerated

884e77f

LPS-92219 Use same ordering

d953688

LPS-92219 Make method private

fc7c75a

LPS-92219 Auto SF

8530ce2

liferay-continuous-integration added ci:test:relevant - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Apr 11, 2019

liferay-continuous-integration closed this Apr 11, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Apr 11, 2019

liferay-continuous-integration reopened this Apr 11, 2019

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure labels Apr 11, 2019

brianchandotcom closed this Apr 11, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Apr 11, 2019

LPS-92219 Make regular users see other group members on autocomplete #71342

LPS-92219 Make regular users see other group members on autocomplete #71342

Conversation

adolfopa commented Apr 11, 2019

liferay-continuous-integration commented Apr 11, 2019

liferay-continuous-integration commented Apr 11, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 52 seconds 864 ms

Base Branch:

Sender Branch:

For more details click here.

adolfopa commented Apr 11, 2019

liferay-continuous-integration commented Apr 11, 2019

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Apr 11, 2019

❌ ci:test:relevant - 66 out of 88 jobs passed in 2 hours 24 minutes 25 seconds 323 ms

Base Branch:

Copied in Private Modules Branch:

22 Failed Jobs:

For more details click here.

Failures (upstream comparison is not available):

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

For upstream results, click here.

adolfopa commented Apr 11, 2019

adolfopa commented Apr 11, 2019

brianchandotcom commented Apr 11, 2019

liferay-continuous-integration commented Apr 11, 2019

❌ ci:test:relevant - 67 out of 88 jobs passed in 2 hours 17 minutes 9 seconds 140 ms

Base Branch:

Copied in Private Modules Branch:

21 Failed Jobs:

For more details click here.

This pull contains no unique failures.

Job Results:

Job Results:

Job Results:

Job Results:

Job Results: