Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-94196 Check destroyOnHide attribute to provide different behaviour in case of content creation redirect and normal modal hide #71769

Closed
wants to merge 1 commit into from
Closed

LPS-94196 Check destroyOnHide attribute to provide different behaviour in case of content creation redirect and normal modal hide #71769

wants to merge 1 commit into from

Conversation

pavel-savinov
Copy link

No description provided.

@pavel-savinov
LPS-94196 Check destroyOnHide attribute to provide different behaviou…
31571fd 
…r in case of content creation redirect and normal modal hide
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 42 minutes 23 seconds 102 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0313d31dc23946474e8cf5c24aa46010446c2694

Sender Branch:

Branch Name: LPS-94196
Branch GIT ID: 31571fdbdd58f86ed5d27f10fd628535ebfae6a3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@pavel-savinov

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
Job Results:

6 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #293256
    1. ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Artifact dependency {classpath group: "com.liferay", name: "com.liferay.gradle.plugins.defaults", version: "latest.release"} in modules/apps/analytics/build.gradle not permitted on master branch. Use a project dependency instead.
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1319)
	at com.liferay.portal.modules.ModulesStructureTest.access$700(ModulesStructureTest.java:66)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:338)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:313)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:311)
cc @

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 23 out of 27 jobs passed in 1 hour 34 minutes 42 seconds 433 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0313d31dc23946474e8cf5c24aa46010446c2694

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 997fee77d3d18bccb1ebec2ef825185cb211f553

23 out of 27 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures (upstream comparison is not available):

  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
    Job Results:

    6 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #293256
      1. ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Artifact dependency {classpath group: "com.liferay", name: "com.liferay.gradle.plugins.defaults", version: "latest.release"} in modules/apps/analytics/build.gradle not permitted on master branch. Use a project dependency instead.
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1319)
	at com.liferay.portal.modules.ModulesStructureTest.access$700(ModulesStructureTest.java:66)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:338)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:313)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:311)
  3. test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
    Job Results:

    4 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #290500
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to save metadata for file version 39035
java.lang.NullPointerException
	at com.liferay.portlet.documentlibrary.util.RawMetadataProcessorImpl.saveMetadata(RawMetadataProcessorImpl.java:188)
	at com.liferay.document.library.kernel.util.RawMetadataProcessorUtil.saveMetadata(RawMetadataProcessorUtil.java:113)
	at com.liferay.portlet.documentlibrary.messaging.RawMetadataProcessorMessageListener.doReceive(RawMetadataProcessorMessageListener.java:34)
	at com.liferay.portal.kernel.messaging.BaseMessageListener.receive(BaseMessageListener.java:26)
	at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
	at com.liferay.portal.kernel.messaging.SerialDestination$1.run(SerialDestination.java:58)
	at com.liferay.portal.kernel.concurrent.ThreadPoolExecutor$WorkerTask._runTask(ThreadPoolExecutor.java:752)
	at com.liferay.portal.kernel.concurrent.ThreadPoolExecutor$WorkerTask.run(ThreadPoolExecutor.java:664)
	at java.lang.Thread.run(Thread.java:745)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.assertor.Porta...</code></pre></div></li></ol></div></li></ol></div></li></ol><h4>For upstream results, click <a href="https://test-1-1.liferay.com/job/test-portal-acceptance-upstream(master)">here</a>.</h4></details></html>

@jpince
Copy link
Collaborator

jpince commented Apr 17, 2019

ci:reopen

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavel-savinov @liferay-continuous-integration @jpince @brianchandotcom